Skip to content
Success

Changes

Summary

  1. Fix deep copy when filling Rank-7 views (details)
  2. TestViewCopy_c.hpp: add new unit test for deep copy (ViewFill) (details)
  3. TestViewCopy_c.hpp: better handling for OpenMPTarget (details)
  4. Do not return a copy of the input functor for Kokkos::Experimental::for_each (details)
  5. Accommodate users that depend on a code that define silly macros (#6909) (details)
  6. SYCL: Fix multi-GPU support and add test (#6887) (details)
  7. SYCL: Unroll shuffle loops for top-level parallel_reduce and parallel_scan (#6750) (details)
  8. Preparing readme for develop as the default branch (#6796) (details)
  9. CHANGELOG.md: 4.3.00 update (details)
  10. Refactor: Uniformize `create_mirror*` parameter name for views (#6917) (details)
  11. SYCL: Improve team_reduce implementation (#6562) (details)
  12. Enhanced test and renamed functions (details)
Commit 841b3a9f96eecb28bcc637ea6e5fbe63c9e3e92d by cedric.chevalier
Fix deep copy when filling Rank-7 views

Typo in loop indices, from wrong copy-paste.
The file was modified core/src/Kokkos_CopyViews.hpp (diff)
Commit a2f2ba4049c89ee0085712ee15ba22160ae3baf3 by cedric.chevalier
TestViewCopy_c.hpp: add new unit test for deep copy (ViewFill)
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was modified core/unit_test/Makefile (diff)
The file was addedcore/unit_test/TestViewCopy_c.hpp
The file was modified core/src/Kokkos_CopyViews.hpp (diff)
Commit ae4d0013dd0a7ae4b3cd036a3ae9f0eb9002bea7 by cedric.chevalier
TestViewCopy_c.hpp: better handling for OpenMPTarget

Disabling call to value checker as it is not supported by the backend.
The file was modified core/unit_test/TestViewCopy_c.hpp (diff)
Commit 391e0408bed63b0ca0758da5dacb75a70677d0f7 by thomas.padioleau
Do not return a copy of the input functor for Kokkos::Experimental::for_each
The file was modified algorithms/src/std_algorithms/Kokkos_ForEach.hpp (diff)
The file was modified algorithms/src/std_algorithms/impl/Kokkos_ForEachForEachN.hpp (diff)
Commit 059cd15c0b2c23443d2e870bcfe767611386157f by noreply
Accommodate users that depend on a code that define silly macros (#6909)

* Accommodate users that depend on a code that define silly macros

Reported on Slack, user was getting when including some other dependency
```
<prefix>/include/Kokkos_Tuners.hpp(259): error: expected a "," or ">"
template <typename PointType, size_t 0>
                    ^
```
It turns out that dependency defines macros such as "X", "Y", "Z", or
even "DIM" which is really asking for trouble.  See here
https://github.com/fluiddynsci/EngSketchPad/blob/1fe3fc4c68a759e0832c02f8d3c2bd8722f183a8/include/libCart3D/c3d_global.h#L24-L28

Since it does not take much change to accommodate that user, we avoid
named parameters that collide with these silly macro defines.
We are not promising that we support it but this should help.

* Per review rename SZ -> ArraySize
The file was modified core/src/Kokkos_Tuners.hpp (diff)
Commit 2aecb1d2412eca0729f3bc3da9e10c215c17da78 by noreply
SYCL: Fix multi-GPU support and add test (#6887)

* SYCL: Fix multi-GPU support and add test

* Combine Cuda and SYCL test

* Drop exception_handler
The file was addedcore/unit_test/TestMultiGPU.hpp
The file was addedcore/unit_test/sycl/TestSYCL_InterOp_StreamsMultiGPU.cpp
The file was modified core/unit_test/cuda/TestCuda_InterOp_StreamsMultiGPU.cpp (diff)
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_Instance.cpp (diff)
Commit caa139c9b9307c88599bbe9e5e180b6db44692e4 by noreply
SYCL: Unroll shuffle loops for top-level parallel_reduce and parallel_scan (#6750)

* SYCL: Unroll shuffle loops for top-level parallel_reduce and parallel_scan

* Rename second lambda

* Assert upper bounds and remove unattainable cases

* Fix sign comparison warnings
The file was modified core/src/SYCL/Kokkos_SYCL_ParallelScan_Range.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_WorkgroupReduction.hpp (diff)
Commit a833fb00ba79b36354fd45e3fbae1e1621e187d0 by noreply
Preparing readme for develop as the default branch (#6796)

* Add 'Quick Start' section to README.md

Added an extensive 'Quick Start' guide to the README.md document, which includes instructions for obtaining the latest release of Kokkos, building Kokkos for different platforms such as CPU on Linux or macOS, CUDA on Linux, and HIP on Linux, and using Kokkos in a CMake project.

* Update hyperlinks in README.md

The previous links pointing to kokkos.github.io have been changed to point correctly to kokkos.org.

* Refine instructions for getting and building Kokkos in README.md

The README.md file has been updated with simplified, clearer instructions. Changes include refined steps to obtain the latest Kokkos release using curl and to clone the development version of Kokkos from GitHub.

* Add Kokkos installation guide using Spack in README.md

* Reorder Readme and add links

* Readme: Fix typo in cmake option

* Fix typo in Readme

Co-authored-by: Daniel Arndt <arndtd@ornl.gov>

* Readme: update version and hip instructions.

* README: Remove building examples

Adding one liner to get latest release

* Fix a typo

* dalg24 suggestions

Co-authored-by: Damien L-G <dalg24+github@gmail.com>

---------

Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
The file was modified README.md (diff)
Commit 497b438f1f16d63faa55240772b1f0d8681a7a89 by ndellin
CHANGELOG.md: 4.3.00 update
The file was modified CHANGELOG.md (diff)
Commit 4b90930999610dbc60bfdaddfe7ff1385a4fb997 by noreply
Refactor: Uniformize `create_mirror*` parameter name for views (#6917)

* Uniformize view name for create_mirror

* Uniformize view name for create_mirror_view

* Fix formatting
The file was modified core/src/Kokkos_CopyViews.hpp (diff)
Commit 98b1a38e5391c57b866c4b16bf8108fce56d827a by noreply
SYCL: Improve team_reduce implementation (#6562)

* SYCL: Improve team_reduce implementation

* Manually unroll loop to propagate shuffle destinations at compile-time

* Update step_width

* Fix sign comparison warnings

* Comment and choosing step_width=16

* KOKKOS_ASSERT that the subgroup range doesn't exceed 32

* Remove unattainable cases

* Add a barrier guarding the reduction array upon exiting team_reduce

* Update comment to better reflect intent of barrier

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
The file was modified core/src/SYCL/Kokkos_SYCL_Team.hpp (diff)
Commit 2f5ce8eabf32b08c842ae1de409c18dca1c05a9e by donlee
Enhanced test and renamed functions
The file was modified core/unit_test/TestMDRangePolicyConstructors.hpp (diff)
The file was modified core/src/KokkosExp_MDRangePolicy.hpp (diff)