Skip to content
Success

Changes

Summary

  1. Bump Google Benchmark version v1.{6.2 -> 7.1} in CMake FetchContent (details)
  2. Remove variadic range policy constructor (#6845) (details)
  3. Avoid unused variable warning in TestRangePolicyCTAD.cpp (details)
  4. Fix C-style cast (details)
  5. Fix amdclang++ compilation (#6857) (details)
  6. Fix fallback implementation for sort_by_key (#6856) (details)
  7. Update the unsafe implicit conversion error message in MDRangePolicy (#6855) (details)
  8. Split some classes from Kokkos_ViewMapping (#6859) (details)
  9. Use rocthrust in sort when using HIP (details)
  10. Fix reviewer's comments (details)
  11. Make sure that we don't compile Kokkos for every supported architecture when enabling rocthrust (details)
Commit 0cdc9eb768582bec4af8f0e44057e235ca8277f0 by Damien L-G
Bump Google Benchmark version v1.{6.2 -> 7.1} in CMake FetchContent
The file was modifiedcore/perf_test/CMakeLists.txt (diff)
Commit 8b8de2cf47cd85005b6adafb8fe5c99b57c32c23 by noreply
Remove variadic range policy constructor (#6845)

* Removed variadic ctor from RangePolicy, as well as extra
set(...) methods.

* In RangePolicy:
Deprecated set(ChunkSize)
In the ctor that takes a ChunkSize, set the chunk size via
set_chunk_size instead of via member initializers (to be more consistent
with other code)

* Removed superfluous "inline" from two of the RangePolicy constructors
The file was modifiedcore/src/Kokkos_ExecPolicy.hpp (diff)
Commit dc524910d397feb7050b39f34d38dfd7d4f82b65 by Daniel Arndt
Avoid unused variable warning in TestRangePolicyCTAD.cpp
The file was modifiedcore/unit_test/TestRangePolicyCTAD.cpp (diff)
The file was modifiedcore/src/Serial/Kokkos_Serial_Task.hpp (diff)
Commit 99c7e1b1c430f2012eaea2f4bec90e8e0858b9f9 by noreply
Fix amdclang++ compilation (#6857)

* Fix amdclang++ compilation

* Add guards for hipcc
The file was modifiedcmake/kokkos_arch.cmake (diff)
Commit 9feb104d9b3ce86230f1b56c6207246f67f22de1 by noreply
Fix fallback implementation for sort_by_key (#6856)

* Fix fallback implementation for sort_by_key

* Guard with KOKKOS_ENABLE_ONEDPL

* Drop sort_on_device

* Improve wording

* Improve comment
The file was modifiedalgorithms/src/sorting/impl/Kokkos_SortByKeyImpl.hpp (diff)
Commit c3c8a70d21ffe88f810bfe392fb5a0457c62c928 by noreply
Update the unsafe implicit conversion error message in MDRangePolicy (#6855)

* Updated the error message in MDRangePolicy about unsafe implicit conversions

* Addressed clang warnings
The file was modifiedcore/src/KokkosExp_MDRangePolicy.hpp (diff)
The file was modifiedcore/unit_test/TestMDRangePolicyConstructors.hpp (diff)
Commit 9a7e7958ae6e35124546663936520f93f964d021 by noreply
Split some classes from Kokkos_ViewMapping (#6859)

* move ViewOffset and ViewDataAnalysis to a separate header

* only include Kokkos_Macro in ViewDataAnalysis
The file was modifiedcore/src/impl/Kokkos_ViewMapping.hpp (diff)
The file was addedcore/src/impl/Kokkos_ViewDataAnalysis.hpp
Commit 2d106d5fd494b31187ac31cbf15d801b4858df5c by Bruno Turcksin
Use rocthrust in sort when using HIP
The file was modifiedalgorithms/src/sorting/impl/Kokkos_SortImpl.hpp (diff)
The file was modifiedcmake/KokkosCore_config.h.in (diff)
The file was modifiedcontainers/src/CMakeLists.txt (diff)
The file was addedcmake/Modules/FindTPLROCTHRUST.cmake
The file was modifiedcmake/kokkos_tpls.cmake (diff)
The file was modified.jenkins (diff)
The file was modifiedalgorithms/src/CMakeLists.txt (diff)
The file was modifiedcontainers/src/CMakeLists.txt (diff)
The file was modifiedcore/src/HIP/Kokkos_HIP_Instance.cpp (diff)
Commit da500f41045b18bc7f30fd2243e6a8ea24c21f95 by Bruno Turcksin
Make sure that we don't compile Kokkos for every supported architecture when enabling rocthrust
The file was modifiedcmake/Modules/FindTPLROCTHRUST.cmake (diff)

Summary

  1. Bump Google Benchmark version v1.{6.2 -> 7.1} in CMake FetchContent (details)
  2. Remove variadic range policy constructor (#6845) (details)
  3. Avoid unused variable warning in TestRangePolicyCTAD.cpp (details)
  4. Fix C-style cast (details)
  5. Fix amdclang++ compilation (#6857) (details)
  6. Fix fallback implementation for sort_by_key (#6856) (details)
  7. Update the unsafe implicit conversion error message in MDRangePolicy (#6855) (details)
  8. Split some classes from Kokkos_ViewMapping (#6859) (details)
  9. Use rocthrust in sort when using HIP (details)
  10. Fix reviewer's comments (details)
  11. Make sure that we don't compile Kokkos for every supported architecture when enabling rocthrust (details)
Commit 0cdc9eb768582bec4af8f0e44057e235ca8277f0 by Damien L-G
Bump Google Benchmark version v1.{6.2 -> 7.1} in CMake FetchContent
The file was modifiedcore/perf_test/CMakeLists.txt (diff)
Commit 8b8de2cf47cd85005b6adafb8fe5c99b57c32c23 by noreply
Remove variadic range policy constructor (#6845)

* Removed variadic ctor from RangePolicy, as well as extra
set(...) methods.

* In RangePolicy:
Deprecated set(ChunkSize)
In the ctor that takes a ChunkSize, set the chunk size via
set_chunk_size instead of via member initializers (to be more consistent
with other code)

* Removed superfluous "inline" from two of the RangePolicy constructors
The file was modifiedcore/src/Kokkos_ExecPolicy.hpp (diff)
Commit dc524910d397feb7050b39f34d38dfd7d4f82b65 by Daniel Arndt
Avoid unused variable warning in TestRangePolicyCTAD.cpp
The file was modifiedcore/unit_test/TestRangePolicyCTAD.cpp (diff)
The file was modifiedcore/src/Serial/Kokkos_Serial_Task.hpp (diff)
Commit 99c7e1b1c430f2012eaea2f4bec90e8e0858b9f9 by noreply
Fix amdclang++ compilation (#6857)

* Fix amdclang++ compilation

* Add guards for hipcc
The file was modifiedcmake/kokkos_arch.cmake (diff)
Commit 9feb104d9b3ce86230f1b56c6207246f67f22de1 by noreply
Fix fallback implementation for sort_by_key (#6856)

* Fix fallback implementation for sort_by_key

* Guard with KOKKOS_ENABLE_ONEDPL

* Drop sort_on_device

* Improve wording

* Improve comment
The file was modifiedalgorithms/src/sorting/impl/Kokkos_SortByKeyImpl.hpp (diff)
Commit c3c8a70d21ffe88f810bfe392fb5a0457c62c928 by noreply
Update the unsafe implicit conversion error message in MDRangePolicy (#6855)

* Updated the error message in MDRangePolicy about unsafe implicit conversions

* Addressed clang warnings
The file was modifiedcore/unit_test/TestMDRangePolicyConstructors.hpp (diff)
The file was modifiedcore/src/KokkosExp_MDRangePolicy.hpp (diff)
Commit 9a7e7958ae6e35124546663936520f93f964d021 by noreply
Split some classes from Kokkos_ViewMapping (#6859)

* move ViewOffset and ViewDataAnalysis to a separate header

* only include Kokkos_Macro in ViewDataAnalysis
The file was addedcore/src/impl/Kokkos_ViewDataAnalysis.hpp
The file was modifiedcore/src/impl/Kokkos_ViewMapping.hpp (diff)
Commit 2d106d5fd494b31187ac31cbf15d801b4858df5c by Bruno Turcksin
Use rocthrust in sort when using HIP
The file was modifiedalgorithms/src/sorting/impl/Kokkos_SortImpl.hpp (diff)
The file was addedcmake/Modules/FindTPLROCTHRUST.cmake
The file was modifiedcontainers/src/CMakeLists.txt (diff)
The file was modifiedcmake/kokkos_tpls.cmake (diff)
The file was modified.jenkins (diff)
The file was modifiedcmake/KokkosCore_config.h.in (diff)
The file was modifiedcore/src/HIP/Kokkos_HIP_Instance.cpp (diff)
The file was modifiedalgorithms/src/CMakeLists.txt (diff)
The file was modifiedcontainers/src/CMakeLists.txt (diff)
Commit da500f41045b18bc7f30fd2243e6a8ea24c21f95 by Bruno Turcksin
Make sure that we don't compile Kokkos for every supported architecture when enabling rocthrust
The file was modifiedcmake/Modules/FindTPLROCTHRUST.cmake (diff)