Skip to content
Not built

Changes

Summary

  1. Don't use Fedora development version in GitHub CI (details)
  2. Fix Makefile.kokkos for Threads (details)
  3. Fix a bug in Makefile when using AMD GPU architectures (#6892) (details)
  4. Cuda: Fix configuring with CMake 3.28.4 (#6898) (details)
  5. Update Intel GPU architectures in Makefile (#6895) (details)
  6. Move `Kokkos::Array` tests to a more suitable place (#6905) (details)
  7. Accommodate users that depend on a code that define silly macros (#6909) (details)
Commit c1a800650e83da2eb515599f495f9bce2aaba80f by Daniel Arndt
Don't use Fedora development version in GitHub CI
The file was modified .github/workflows/continuous-integration-workflow.yml (diff)
Commit 872dc422ff8b77616ac5884f26b83ced61328ee0 by Daniel Arndt
Fix Makefile.kokkos for Threads
The file was modified Makefile.targets (diff)
Commit 2035e313d7a54f9e1572eb5f315249ea841fb258 by noreply
Fix a bug in Makefile when using AMD GPU architectures (#6892)

* Fix bug in Makefile when using AMD GPU architectures

* Fix indentation

* Fix documentation of the architecture to match the code
The file was modified Makefile.kokkos (diff)
Commit 8d734b0267284c3232e715355eb2c690d305ae3f by noreply
Cuda: Fix configuring with CMake 3.28.4 (#6898)

* Cuda: Fix configuring with CMake 3.29.0

* CMake 3.28.4 is also affected
The file was modified cmake/Modules/FindTPLCUDA.cmake (diff)
Commit 68c66846945c28e7b95ba099f2b4fbbe2b72fd63 by noreply
Update Intel GPU architectures in Makefile (#6895)

* Update Intel GPU architectures in Makefile

* Add some comments
The file was modified Makefile.kokkos (diff)
Commit 635551058d436885bf3757eb0bd1ea17bbf0abd4 by noreply
Move `Kokkos::Array` tests to a more suitable place (#6905)

* Move Kokkos::Array tests to a more suitable place

* Workaround bogous(?) compile error with Array::operator[] not being constexpr
The file was modified core/unit_test/TestAggregate.hpp (diff)
The file was modified core/unit_test/TestArray.cpp (diff)
Commit 059cd15c0b2c23443d2e870bcfe767611386157f by noreply
Accommodate users that depend on a code that define silly macros (#6909)

* Accommodate users that depend on a code that define silly macros

Reported on Slack, user was getting when including some other dependency
```
<prefix>/include/Kokkos_Tuners.hpp(259): error: expected a "," or ">"
template <typename PointType, size_t 0>
                    ^
```
It turns out that dependency defines macros such as "X", "Y", "Z", or
even "DIM" which is really asking for trouble.  See here
https://github.com/fluiddynsci/EngSketchPad/blob/1fe3fc4c68a759e0832c02f8d3c2bd8722f183a8/include/libCart3D/c3d_global.h#L24-L28

Since it does not take much change to accommodate that user, we avoid
named parameters that collide with these silly macro defines.
We are not promising that we support it but this should help.

* Per review rename SZ -> ArraySize
The file was modified core/src/Kokkos_Tuners.hpp (diff)

Summary

  1. Don't use Fedora development version in GitHub CI (details)
  2. Fix Makefile.kokkos for Threads (details)
  3. Fix a bug in Makefile when using AMD GPU architectures (#6892) (details)
  4. Cuda: Fix configuring with CMake 3.28.4 (#6898) (details)
  5. Update Intel GPU architectures in Makefile (#6895) (details)
  6. Move `Kokkos::Array` tests to a more suitable place (#6905) (details)
  7. Accommodate users that depend on a code that define silly macros (#6909) (details)
Commit c1a800650e83da2eb515599f495f9bce2aaba80f by Daniel Arndt
Don't use Fedora development version in GitHub CI
The file was modified .github/workflows/continuous-integration-workflow.yml (diff)
Commit 872dc422ff8b77616ac5884f26b83ced61328ee0 by Daniel Arndt
Fix Makefile.kokkos for Threads
The file was modified Makefile.targets (diff)
Commit 2035e313d7a54f9e1572eb5f315249ea841fb258 by noreply
Fix a bug in Makefile when using AMD GPU architectures (#6892)

* Fix bug in Makefile when using AMD GPU architectures

* Fix indentation

* Fix documentation of the architecture to match the code
The file was modified Makefile.kokkos (diff)
Commit 8d734b0267284c3232e715355eb2c690d305ae3f by noreply
Cuda: Fix configuring with CMake 3.28.4 (#6898)

* Cuda: Fix configuring with CMake 3.29.0

* CMake 3.28.4 is also affected
The file was modified cmake/Modules/FindTPLCUDA.cmake (diff)
Commit 68c66846945c28e7b95ba099f2b4fbbe2b72fd63 by noreply
Update Intel GPU architectures in Makefile (#6895)

* Update Intel GPU architectures in Makefile

* Add some comments
The file was modified Makefile.kokkos (diff)
Commit 635551058d436885bf3757eb0bd1ea17bbf0abd4 by noreply
Move `Kokkos::Array` tests to a more suitable place (#6905)

* Move Kokkos::Array tests to a more suitable place

* Workaround bogous(?) compile error with Array::operator[] not being constexpr
The file was modified core/unit_test/TestAggregate.hpp (diff)
The file was modified core/unit_test/TestArray.cpp (diff)
Commit 059cd15c0b2c23443d2e870bcfe767611386157f by noreply
Accommodate users that depend on a code that define silly macros (#6909)

* Accommodate users that depend on a code that define silly macros

Reported on Slack, user was getting when including some other dependency
```
<prefix>/include/Kokkos_Tuners.hpp(259): error: expected a "," or ">"
template <typename PointType, size_t 0>
                    ^
```
It turns out that dependency defines macros such as "X", "Y", "Z", or
even "DIM" which is really asking for trouble.  See here
https://github.com/fluiddynsci/EngSketchPad/blob/1fe3fc4c68a759e0832c02f8d3c2bd8722f183a8/include/libCart3D/c3d_global.h#L24-L28

Since it does not take much change to accommodate that user, we avoid
named parameters that collide with these silly macro defines.
We are not promising that we support it but this should help.

* Per review rename SZ -> ArraySize
The file was modified core/src/Kokkos_Tuners.hpp (diff)

Summary

  1. Don't use Fedora development version in GitHub CI (details)
  2. Fix Makefile.kokkos for Threads (details)
  3. Fix a bug in Makefile when using AMD GPU architectures (#6892) (details)
  4. Cuda: Fix configuring with CMake 3.28.4 (#6898) (details)
  5. Update Intel GPU architectures in Makefile (#6895) (details)
  6. Move `Kokkos::Array` tests to a more suitable place (#6905) (details)
  7. Accommodate users that depend on a code that define silly macros (#6909) (details)
Commit c1a800650e83da2eb515599f495f9bce2aaba80f by Daniel Arndt
Don't use Fedora development version in GitHub CI
The file was modified .github/workflows/continuous-integration-workflow.yml (diff)
Commit 872dc422ff8b77616ac5884f26b83ced61328ee0 by Daniel Arndt
Fix Makefile.kokkos for Threads
The file was modified Makefile.targets (diff)
Commit 2035e313d7a54f9e1572eb5f315249ea841fb258 by noreply
Fix a bug in Makefile when using AMD GPU architectures (#6892)

* Fix bug in Makefile when using AMD GPU architectures

* Fix indentation

* Fix documentation of the architecture to match the code
The file was modified Makefile.kokkos (diff)
Commit 8d734b0267284c3232e715355eb2c690d305ae3f by noreply
Cuda: Fix configuring with CMake 3.28.4 (#6898)

* Cuda: Fix configuring with CMake 3.29.0

* CMake 3.28.4 is also affected
The file was modified cmake/Modules/FindTPLCUDA.cmake (diff)
Commit 68c66846945c28e7b95ba099f2b4fbbe2b72fd63 by noreply
Update Intel GPU architectures in Makefile (#6895)

* Update Intel GPU architectures in Makefile

* Add some comments
The file was modified Makefile.kokkos (diff)
Commit 635551058d436885bf3757eb0bd1ea17bbf0abd4 by noreply
Move `Kokkos::Array` tests to a more suitable place (#6905)

* Move Kokkos::Array tests to a more suitable place

* Workaround bogous(?) compile error with Array::operator[] not being constexpr
The file was modified core/unit_test/TestArray.cpp (diff)
The file was modified core/unit_test/TestAggregate.hpp (diff)
Commit 059cd15c0b2c23443d2e870bcfe767611386157f by noreply
Accommodate users that depend on a code that define silly macros (#6909)

* Accommodate users that depend on a code that define silly macros

Reported on Slack, user was getting when including some other dependency
```
<prefix>/include/Kokkos_Tuners.hpp(259): error: expected a "," or ">"
template <typename PointType, size_t 0>
                    ^
```
It turns out that dependency defines macros such as "X", "Y", "Z", or
even "DIM" which is really asking for trouble.  See here
https://github.com/fluiddynsci/EngSketchPad/blob/1fe3fc4c68a759e0832c02f8d3c2bd8722f183a8/include/libCart3D/c3d_global.h#L24-L28

Since it does not take much change to accommodate that user, we avoid
named parameters that collide with these silly macro defines.
We are not promising that we support it but this should help.

* Per review rename SZ -> ArraySize
The file was modified core/src/Kokkos_Tuners.hpp (diff)

Summary

  1. Don't use Fedora development version in GitHub CI (details)
  2. Fix Makefile.kokkos for Threads (details)
  3. Fix a bug in Makefile when using AMD GPU architectures (#6892) (details)
  4. Cuda: Fix configuring with CMake 3.28.4 (#6898) (details)
  5. Update Intel GPU architectures in Makefile (#6895) (details)
  6. Move `Kokkos::Array` tests to a more suitable place (#6905) (details)
  7. Accommodate users that depend on a code that define silly macros (#6909) (details)
Commit c1a800650e83da2eb515599f495f9bce2aaba80f by Daniel Arndt
Don't use Fedora development version in GitHub CI
The file was modified .github/workflows/continuous-integration-workflow.yml (diff)
Commit 872dc422ff8b77616ac5884f26b83ced61328ee0 by Daniel Arndt
Fix Makefile.kokkos for Threads
The file was modified Makefile.targets (diff)
Commit 2035e313d7a54f9e1572eb5f315249ea841fb258 by noreply
Fix a bug in Makefile when using AMD GPU architectures (#6892)

* Fix bug in Makefile when using AMD GPU architectures

* Fix indentation

* Fix documentation of the architecture to match the code
The file was modified Makefile.kokkos (diff)
Commit 8d734b0267284c3232e715355eb2c690d305ae3f by noreply
Cuda: Fix configuring with CMake 3.28.4 (#6898)

* Cuda: Fix configuring with CMake 3.29.0

* CMake 3.28.4 is also affected
The file was modified cmake/Modules/FindTPLCUDA.cmake (diff)
Commit 68c66846945c28e7b95ba099f2b4fbbe2b72fd63 by noreply
Update Intel GPU architectures in Makefile (#6895)

* Update Intel GPU architectures in Makefile

* Add some comments
The file was modified Makefile.kokkos (diff)
Commit 635551058d436885bf3757eb0bd1ea17bbf0abd4 by noreply
Move `Kokkos::Array` tests to a more suitable place (#6905)

* Move Kokkos::Array tests to a more suitable place

* Workaround bogous(?) compile error with Array::operator[] not being constexpr
The file was modified core/unit_test/TestArray.cpp (diff)
The file was modified core/unit_test/TestAggregate.hpp (diff)
Commit 059cd15c0b2c23443d2e870bcfe767611386157f by noreply
Accommodate users that depend on a code that define silly macros (#6909)

* Accommodate users that depend on a code that define silly macros

Reported on Slack, user was getting when including some other dependency
```
<prefix>/include/Kokkos_Tuners.hpp(259): error: expected a "," or ">"
template <typename PointType, size_t 0>
                    ^
```
It turns out that dependency defines macros such as "X", "Y", "Z", or
even "DIM" which is really asking for trouble.  See here
https://github.com/fluiddynsci/EngSketchPad/blob/1fe3fc4c68a759e0832c02f8d3c2bd8722f183a8/include/libCart3D/c3d_global.h#L24-L28

Since it does not take much change to accommodate that user, we avoid
named parameters that collide with these silly macro defines.
We are not promising that we support it but this should help.

* Per review rename SZ -> ArraySize
The file was modified core/src/Kokkos_Tuners.hpp (diff)

Summary

  1. Don't use Fedora development version in GitHub CI (details)
  2. Fix Makefile.kokkos for Threads (details)
  3. Fix a bug in Makefile when using AMD GPU architectures (#6892) (details)
  4. Cuda: Fix configuring with CMake 3.28.4 (#6898) (details)
  5. Update Intel GPU architectures in Makefile (#6895) (details)
  6. Move `Kokkos::Array` tests to a more suitable place (#6905) (details)
  7. Accommodate users that depend on a code that define silly macros (#6909) (details)
Commit c1a800650e83da2eb515599f495f9bce2aaba80f by Daniel Arndt
Don't use Fedora development version in GitHub CI
The file was modified .github/workflows/continuous-integration-workflow.yml (diff)
Commit 872dc422ff8b77616ac5884f26b83ced61328ee0 by Daniel Arndt
Fix Makefile.kokkos for Threads
The file was modified Makefile.targets (diff)
Commit 2035e313d7a54f9e1572eb5f315249ea841fb258 by noreply
Fix a bug in Makefile when using AMD GPU architectures (#6892)

* Fix bug in Makefile when using AMD GPU architectures

* Fix indentation

* Fix documentation of the architecture to match the code
The file was modified Makefile.kokkos (diff)
Commit 8d734b0267284c3232e715355eb2c690d305ae3f by noreply
Cuda: Fix configuring with CMake 3.28.4 (#6898)

* Cuda: Fix configuring with CMake 3.29.0

* CMake 3.28.4 is also affected
The file was modified cmake/Modules/FindTPLCUDA.cmake (diff)
Commit 68c66846945c28e7b95ba099f2b4fbbe2b72fd63 by noreply
Update Intel GPU architectures in Makefile (#6895)

* Update Intel GPU architectures in Makefile

* Add some comments
The file was modified Makefile.kokkos (diff)
Commit 635551058d436885bf3757eb0bd1ea17bbf0abd4 by noreply
Move `Kokkos::Array` tests to a more suitable place (#6905)

* Move Kokkos::Array tests to a more suitable place

* Workaround bogous(?) compile error with Array::operator[] not being constexpr
The file was modified core/unit_test/TestAggregate.hpp (diff)
The file was modified core/unit_test/TestArray.cpp (diff)
Commit 059cd15c0b2c23443d2e870bcfe767611386157f by noreply
Accommodate users that depend on a code that define silly macros (#6909)

* Accommodate users that depend on a code that define silly macros

Reported on Slack, user was getting when including some other dependency
```
<prefix>/include/Kokkos_Tuners.hpp(259): error: expected a "," or ">"
template <typename PointType, size_t 0>
                    ^
```
It turns out that dependency defines macros such as "X", "Y", "Z", or
even "DIM" which is really asking for trouble.  See here
https://github.com/fluiddynsci/EngSketchPad/blob/1fe3fc4c68a759e0832c02f8d3c2bd8722f183a8/include/libCart3D/c3d_global.h#L24-L28

Since it does not take much change to accommodate that user, we avoid
named parameters that collide with these silly macro defines.
We are not promising that we support it but this should help.

* Per review rename SZ -> ArraySize
The file was modified core/src/Kokkos_Tuners.hpp (diff)

Summary

  1. Don't use Fedora development version in GitHub CI (details)
  2. Fix Makefile.kokkos for Threads (details)
  3. Fix a bug in Makefile when using AMD GPU architectures (#6892) (details)
  4. Cuda: Fix configuring with CMake 3.28.4 (#6898) (details)
  5. Update Intel GPU architectures in Makefile (#6895) (details)
  6. Move `Kokkos::Array` tests to a more suitable place (#6905) (details)
  7. Accommodate users that depend on a code that define silly macros (#6909) (details)
Commit c1a800650e83da2eb515599f495f9bce2aaba80f by Daniel Arndt
Don't use Fedora development version in GitHub CI
The file was modified .github/workflows/continuous-integration-workflow.yml (diff)
Commit 872dc422ff8b77616ac5884f26b83ced61328ee0 by Daniel Arndt
Fix Makefile.kokkos for Threads
The file was modified Makefile.targets (diff)
Commit 2035e313d7a54f9e1572eb5f315249ea841fb258 by noreply
Fix a bug in Makefile when using AMD GPU architectures (#6892)

* Fix bug in Makefile when using AMD GPU architectures

* Fix indentation

* Fix documentation of the architecture to match the code
The file was modified Makefile.kokkos (diff)
Commit 8d734b0267284c3232e715355eb2c690d305ae3f by noreply
Cuda: Fix configuring with CMake 3.28.4 (#6898)

* Cuda: Fix configuring with CMake 3.29.0

* CMake 3.28.4 is also affected
The file was modified cmake/Modules/FindTPLCUDA.cmake (diff)
Commit 68c66846945c28e7b95ba099f2b4fbbe2b72fd63 by noreply
Update Intel GPU architectures in Makefile (#6895)

* Update Intel GPU architectures in Makefile

* Add some comments
The file was modified Makefile.kokkos (diff)
Commit 635551058d436885bf3757eb0bd1ea17bbf0abd4 by noreply
Move `Kokkos::Array` tests to a more suitable place (#6905)

* Move Kokkos::Array tests to a more suitable place

* Workaround bogous(?) compile error with Array::operator[] not being constexpr
The file was modified core/unit_test/TestAggregate.hpp (diff)
The file was modified core/unit_test/TestArray.cpp (diff)
Commit 059cd15c0b2c23443d2e870bcfe767611386157f by noreply
Accommodate users that depend on a code that define silly macros (#6909)

* Accommodate users that depend on a code that define silly macros

Reported on Slack, user was getting when including some other dependency
```
<prefix>/include/Kokkos_Tuners.hpp(259): error: expected a "," or ">"
template <typename PointType, size_t 0>
                    ^
```
It turns out that dependency defines macros such as "X", "Y", "Z", or
even "DIM" which is really asking for trouble.  See here
https://github.com/fluiddynsci/EngSketchPad/blob/1fe3fc4c68a759e0832c02f8d3c2bd8722f183a8/include/libCart3D/c3d_global.h#L24-L28

Since it does not take much change to accommodate that user, we avoid
named parameters that collide with these silly macro defines.
We are not promising that we support it but this should help.

* Per review rename SZ -> ArraySize
The file was modified core/src/Kokkos_Tuners.hpp (diff)

Summary

  1. Don't use Fedora development version in GitHub CI (details)
  2. Fix Makefile.kokkos for Threads (details)
  3. Fix a bug in Makefile when using AMD GPU architectures (#6892) (details)
  4. Cuda: Fix configuring with CMake 3.28.4 (#6898) (details)
  5. Update Intel GPU architectures in Makefile (#6895) (details)
  6. Move `Kokkos::Array` tests to a more suitable place (#6905) (details)
  7. Accommodate users that depend on a code that define silly macros (#6909) (details)
Commit c1a800650e83da2eb515599f495f9bce2aaba80f by Daniel Arndt
Don't use Fedora development version in GitHub CI
The file was modified .github/workflows/continuous-integration-workflow.yml (diff)
Commit 872dc422ff8b77616ac5884f26b83ced61328ee0 by Daniel Arndt
Fix Makefile.kokkos for Threads
The file was modified Makefile.targets (diff)
Commit 2035e313d7a54f9e1572eb5f315249ea841fb258 by noreply
Fix a bug in Makefile when using AMD GPU architectures (#6892)

* Fix bug in Makefile when using AMD GPU architectures

* Fix indentation

* Fix documentation of the architecture to match the code
The file was modified Makefile.kokkos (diff)
Commit 8d734b0267284c3232e715355eb2c690d305ae3f by noreply
Cuda: Fix configuring with CMake 3.28.4 (#6898)

* Cuda: Fix configuring with CMake 3.29.0

* CMake 3.28.4 is also affected
The file was modified cmake/Modules/FindTPLCUDA.cmake (diff)
Commit 68c66846945c28e7b95ba099f2b4fbbe2b72fd63 by noreply
Update Intel GPU architectures in Makefile (#6895)

* Update Intel GPU architectures in Makefile

* Add some comments
The file was modified Makefile.kokkos (diff)
Commit 635551058d436885bf3757eb0bd1ea17bbf0abd4 by noreply
Move `Kokkos::Array` tests to a more suitable place (#6905)

* Move Kokkos::Array tests to a more suitable place

* Workaround bogous(?) compile error with Array::operator[] not being constexpr
The file was modified core/unit_test/TestAggregate.hpp (diff)
The file was modified core/unit_test/TestArray.cpp (diff)
Commit 059cd15c0b2c23443d2e870bcfe767611386157f by noreply
Accommodate users that depend on a code that define silly macros (#6909)

* Accommodate users that depend on a code that define silly macros

Reported on Slack, user was getting when including some other dependency
```
<prefix>/include/Kokkos_Tuners.hpp(259): error: expected a "," or ">"
template <typename PointType, size_t 0>
                    ^
```
It turns out that dependency defines macros such as "X", "Y", "Z", or
even "DIM" which is really asking for trouble.  See here
https://github.com/fluiddynsci/EngSketchPad/blob/1fe3fc4c68a759e0832c02f8d3c2bd8722f183a8/include/libCart3D/c3d_global.h#L24-L28

Since it does not take much change to accommodate that user, we avoid
named parameters that collide with these silly macro defines.
We are not promising that we support it but this should help.

* Per review rename SZ -> ArraySize
The file was modified core/src/Kokkos_Tuners.hpp (diff)