Skip to content
Failed

Changes

Summary

  1. Add `kokkos_swap(Array<T, N>)` sepcialization (details)
  2. kokkos_swap(Array) member friend should not be templated on some other type U (details)
  3. Fix noexcept specification for kokkos_swap on zero-sized arrays (details)
  4. Replace deprecated sycl::device_ptr/sycl::host_ptr (details)
  5. Introduce alias based on feature macro (details)
  6. Kokkos::Impl::SYCLTypes:: -> Kokkos::Impl::sycl_ (details)
  7. Fix wrong macro guards for deprecated Kokkos::pair<T1,void> specialization (details)
  8. #6805: add initial converting constructor from mdspan to view (details)
  9. #6805: some formatting fixes (details)
  10. #6805: guard mdspan conversion test (details)
  11. #6805: fix host function call from device and fix more cuda warnings in mdspan (details)
  12. #6805: fix more formatting (details)
  13. #6805: fix constraints on mdspan converting constructor and allow runtime-unmanaged (but compile-time managed) views to be constructed from mdspans (details)
  14. #6805: make mdspan helpers namespace consistent (details)
  15. #6805: add conversion to mdspan (details)
  16. #6805: add to_mdspan (details)
  17. #6805: fix formatting and update tests (details)
  18. #6805: more formatting fixes (details)
  19. #6805: fixes to strided layout and more tests (details)
  20. #6805: fixe compilation with nvcc (details)
  21. #6805: various formatting fixes and cleanup (details)
  22. #6805: clean up implementation slightly (details)
  23. #6805: fix rebase artifact (details)
  24. #6805: add more test types (details)
  25. #6805: fix unused type (details)
  26. Fix more unused types (details)
  27. #6805: fix insufficient array size for strides (details)
  28. #6805: new method for getting strides from ViewOffset (details)
  29. #6805: remove stray character (details)
  30. #6805: address some initial PR comments (details)
  31. #6805: fix dependency on ExecutionSpace template parameter (details)
  32. #6805: move MDSpan impl from Kokkos::Experimental::Impl->Kokkos::Impl (details)
  33. #6805: move dimension_from_extent (details)
  34. #6805: fix formatting (details)
  35. Remove unused functions and structs (details)
  36. Introduce KOKKOS_IMPL_CONDITIONAL_EXPLICIT macro for use in View (details)
  37. Add default accessor_type to to_mdspan funciton (details)
  38. Improve test and fix for C++20 where we need an additional ctor (details)
  39. Fix clang-format (details)
  40. address some more reviewer comments (details)
  41. #6805: fix array overrun bug in stride conversion function (details)
  42. #6805: fix unused parameter on 0 size views (details)
  43. #6805: disable clang formatting for usage of maybe_unused as it gives incorrect C++ (details)
  44. #6805: address PR feedback in test (details)
  45. #6805: fix namespace in test (details)
  46. #6805: move test out of subdirectory (details)
  47. #6805: arrange test alphabetically (details)
  48. #6805: fix test (details)
  49. #6805: use the extent value for constructing static extents in layouts rather than 0 (details)
  50. #6805: remove dimension_from_extent as it is not used anymore (details)
  51. #6805: fix formatting (details)
  52. #6805: switch out conditionally explicit macro for explicit check on C++ version and a comment (details)
  53. #6805: fix constraints on implicit mdspan conversion and test for undesirable implicit conversions (details)
  54. #6805: add test for reproducing padding issue (details)
  55. #6805: use strides for layout_left_padded and layout_right_padded (details)
Commit c9e21ce2ab8e03710494ed53a12c255df56fd3b1 by Damien L-G
Add `kokkos_swap(Array<T, N>)` sepcialization

Specializing the swap algorithm for Kokkos arrays was initially proposed
in #6697 but we dropped it to focus on the Kokkos swap ADL ordeal.
Somehow we overlooked a stray <Kokkos_Swap.hpp> header include in the
Kokkos::Array header file.  This PR reintroduce a
`Kokkos::kokkos_swap(Kokkos::Array)` specialization, following closely
what the standard library does for `std::swap(std::array)`.
The file was modified core/unit_test/TestArray.cpp (diff)
The file was modified core/src/Kokkos_Array.hpp (diff)
Commit 8706b68d5bcb66473f180e131696e3d520bd34a7 by Damien L-G
kokkos_swap(Array) member friend should not be templated on some other type U

Co-Authored-By: Maarten Arnst <maarten.arnst@uliege.be>
The file was modified core/src/Kokkos_Array.hpp (diff)
Commit 86f5988b3128cd751da53d0b0c1af87d4ff7324a by Damien L-G
Fix noexcept specification for kokkos_swap on zero-sized arrays

Co-authored-by: Nevin Liber <nliber@anl.gov>
The file was modified core/src/Kokkos_Array.hpp (diff)
Commit 205fd156d990138dd6b6b400fb44d4aa9b196aa0 by Daniel Arndt
Replace deprecated sycl::device_ptr/sycl::host_ptr
The file was modified core/src/SYCL/Kokkos_SYCL_ParallelReduce_Range.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_ParallelScan_Range.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_WorkgroupReduction.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_Instance.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_ParallelFor_Team.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_ParallelReduce_MDRange.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_ParallelReduce_Team.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_Team.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_Instance.cpp (diff)
Commit 5932685c939a08b1b29b9c56bcb264728c1b16ba by Daniel Arndt
Introduce alias based on feature macro
The file was modified core/src/SYCL/Kokkos_SYCL_Instance.cpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_Team.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_ParallelReduce_Team.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_ParallelScan_Range.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_ParallelReduce_Range.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_ParallelFor_Team.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_Instance.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_WorkgroupReduction.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_ParallelReduce_MDRange.hpp (diff)
The file was modified core/src/setup/Kokkos_Setup_SYCL.hpp (diff)
Commit a7827731cf8256a9387a8786555aa5f97dccd17a by Daniel Arndt
Kokkos::Impl::SYCLTypes:: -> Kokkos::Impl::sycl_
The file was modified core/src/SYCL/Kokkos_SYCL_ParallelReduce_MDRange.hpp (diff)
The file was modified core/src/setup/Kokkos_Setup_SYCL.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_Instance.cpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_Instance.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_WorkgroupReduction.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_ParallelScan_Range.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_ParallelFor_Team.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_ParallelReduce_Range.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_Team.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL_ParallelReduce_Team.hpp (diff)
Commit ab3cae4865aec2114a7fe21288fdab2916b92188 by Damien L-G
Fix wrong macro guards for deprecated Kokkos::pair<T1,void> specialization

Co-Authored-By: Nicolas Morales <nmmoral@sandia.gov>
The file was modified core/src/Kokkos_Pair.hpp (diff)
Commit 537b0f8a0d8993d421ad358411e0b27021939992 by nmmoral
#6805: add initial converting constructor from mdspan to view
The file was addedcore/unit_test/view/TestMDSpanConversion.hpp
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Extents.hpp (diff)
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
The file was addedcore/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp
Commit e18c1fa8bdcc54dbe19f624b1ef8c90295558fe0 by nmmoral
#6805: some formatting fixes
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Extents.hpp (diff)
Commit c63bf06590644941fc2ac02d8c2ffd8e2100e550 by nmmoral
#6805: guard mdspan conversion test
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
Commit a213ee7f41eb36a6946c607e5b7070608d650d24 by nmmoral
#6805: fix host function call from device and fix more cuda warnings in mdspan
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Extents.hpp (diff)
The file was modified tpls/mdspan/include/experimental/__p2642_bits/layout_padded.hpp (diff)
Commit 09003ab1b7ac5f3dfbfc1eb2a6b767fe9604c693 by nmmoral
#6805: fix more formatting
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Extents.hpp (diff)
Commit cd8889866d20f06745778cbcec9664ce40d0cc0c by nmmoral
#6805: fix constraints on mdspan converting constructor and allow runtime-unmanaged (but compile-time managed) views to be constructed from mdspans
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
Commit 0a1c0197a7f3118f0a0c5ae13d98e86891487f91 by nmmoral
#6805: make mdspan helpers namespace consistent
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
Commit 2f1523d889290062ebd4bb3fb3f3d18b97b2e8a5 by nmmoral
#6805: add conversion to mdspan
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Extents.hpp (diff)
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
Commit 4a2ef59318125015a0a2533ae1dfa6a65510e9ca by nmmoral
#6805: add to_mdspan
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
Commit 38db71e4e31c2ba6a11d0479629d8b349d5f8514 by nmmoral
#6805: fix formatting and update tests
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
Commit c2bb4039f383666eebf8bd4e90d9957b33c58135 by nmmoral
#6805: more formatting fixes
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
Commit 6a8ad71fc86eff1010f363b5c8d83f74ef6e1052 by nmmoral
#6805: fixes to strided layout and more tests
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
Commit 848eeb3e62716243ed578f480fe77d58ebc7a376 by nmmoral
#6805: fixe compilation with nvcc
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
Commit 935d302acc6598692b2992bd1518f5f39c29f51a by nmmoral
#6805: various formatting fixes and cleanup
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
Commit 86a9c8a2066432df492f7b78feda3006e3d6c4b1 by nmmoral
#6805: clean up implementation slightly
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
Commit e3e85c848942468aeeda048247d2b19527dbf731 by nmmoral
#6805: fix rebase artifact
The file was modified tpls/mdspan/include/experimental/__p2642_bits/layout_padded.hpp (diff)
Commit fa7259e7c12feca08c90c4e77b40045804899fa7 by nmmoral
#6805: add more test types
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
Commit c353624a4db7004b690023aea1bcc5cd4511bd35 by nmmoral
#6805: fix unused type
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
Commit 0587df4eaca2df0b3de1502557cf25ee347535cb by nmmoral
Fix more unused types
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
Commit 4c1460eaeb3736623337edf5dcd63d9c486a22ab by nmmoral
#6805: fix insufficient array size for strides
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
Commit 69c5fb42decd5d44c0f6702f10386c442ccabf45 by nmmoral
#6805: new method for getting strides from ViewOffset
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
Commit adc3050cb6040ad385befd2eb4d0c7a5ac60ba0f by nmmoral
#6805: remove stray character
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
Commit 52be4cde29ff381c237b604a18a1c11304882541 by nmmoral
#6805: address some initial PR comments
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Extents.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
Commit aaa7803038c864c9398e0aa143bd3af8f8692068 by nmmoral
#6805: fix dependency on ExecutionSpace template parameter
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
Commit 1a2603f4636899f7ebdf2176e4af6259a2b41b37 by nmmoral
#6805: move MDSpan impl from Kokkos::Experimental::Impl->Kokkos::Impl
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Extents.hpp (diff)
The file was modified core/unit_test/view/TestExtentsDatatypeConversion.cpp (diff)
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
Commit 7c1bf24ece32ad42386ba4e5288cc86d54f9113f by nmmoral
#6805: move dimension_from_extent
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Extents.hpp (diff)
Commit 1b6706dbbc9f8f033129e7c1442a23dc0aff9040 by nmmoral
#6805: fix formatting
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
Commit bcad6ca58fe06c0c46dbacb10ff671ae6d00300d by nmmoral
Remove unused functions and structs
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
Commit ff8aaee0c34e27dd7069c93e3fbc53557b198cc2 by nmmoral
Introduce KOKKOS_IMPL_CONDITIONAL_EXPLICIT macro for use in View
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified core/src/Kokkos_Macros.hpp (diff)
Commit 540ea2ac9357b2bcac354f7b6efaea98ade48b59 by nmmoral
Add default accessor_type to to_mdspan funciton
The file was modified core/src/Kokkos_View.hpp (diff)
Commit b2f00c13e136a2cebedc0626c19bcfeab0bd27da by nmmoral
Improve test and fix for C++20 where we need an additional ctor

This explicit construction:
View<int[8]> a(mdspan<int,dextents<int,1>>(ptr,8))
needs the new ctor, because the mdspan provided is not implicitly
convertible to the natural mdspan type.
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
The file was modified core/src/Kokkos_Macros.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
Commit a7dd41c99b73872ead7f15856945e685323ff9ed by nmmoral
address some more reviewer comments
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified core/src/Kokkos_Macros.hpp (diff)
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
Commit ad45f936cfce829868d7b54b339151a4feabf767 by nmmoral
#6805: fix array overrun bug in stride conversion function
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
Commit dc62626200723a4a162343288d62e457abf9b49d by nmmoral
#6805: fix unused parameter on 0 size views
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
Commit 03550570a3a6cadb9bbc7e7c4c513c5239424e79 by nmmoral
#6805: disable clang formatting for usage of maybe_unused as it gives incorrect C++
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
Commit d87434085bf9cbca863691b5bfbee30d674700a0 by nmmoral
#6805: address PR feedback in test
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
Commit 9b0ace526d6ad36703d107dbe268ec8063dfe38d by nmmoral
#6805: fix namespace in test
The file was modified core/unit_test/view/TestMDSpanConversion.hpp (diff)
Commit 9d701a10f7d9a849cfefbca81e235f84f2983778 by nmmoral
#6805: move test out of subdirectory
The file was removedcore/unit_test/view/TestMDSpanConversion.hpp
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was addedcore/unit_test/TestMDSpanConversion.hpp
Commit eb11df66fc1958542b84ba143fdbfd8e613f013d by nmmoral
#6805: arrange test alphabetically
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was modified core/unit_test/CMakeLists.txt (diff)
Commit b1808829c8156b7f40a7f8a118deec1fdb8003e6 by nmmoral
#6805: use the extent value for constructing static extents in layouts rather than 0
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
Commit 51c9d0f86273cf3aef8d69ef2ba0e824230ad78e by nmmoral
#6805: remove dimension_from_extent as it is not used anymore
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
Commit bcd6d796f9fc66ab92f860529b548beff2b9c859 by nmmoral
#6805: fix formatting
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
Commit dc00faf58d94fe4c1262bab1c8ca835dd0786245 by nmmoral
#6805: switch out conditionally explicit macro for explicit check on C++ version and a comment
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified core/src/Kokkos_Macros.hpp (diff)
Commit 19db560f86387e856ddfb4d184b9f4819441c0d5 by nmmoral
#6805: fix constraints on implicit mdspan conversion and test for undesirable implicit conversions
The file was modified core/unit_test/TestMDSpanConversion.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
Commit c10473deb7422134c022ea30afb993dfc5e03b50 by nmmoral
#6805: add test for reproducing padding issue
The file was modified core/unit_test/TestMDSpanConversion.hpp (diff)
Commit 3cbcde7be39f77a907064a82a55dd3d61a695cec by nmmoral
#6805: use strides for layout_left_padded and layout_right_padded
The file was modified core/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)