Skip to content
Failed

Changes

Summary

  1. SYCL: Cleanup device selection (details)
  2. SYCL CI: Avoid setvars.sh (details)
  3. Cleanup KOKKOS_CONFIGURE_CORE (details)
  4. Update GitHub actions ot use Node 20 (details)
  5. [4.2.01]: changelog update  (#6656) (details)
  6. Clean up shift_{right, left}_team_impl (#6821) (details)
  7. Avoid detecting unwanted fences in the parallel_scan_no_fence test (details)
  8. Add test for current CTAD support with RangePolicy (#6803) (details)
  9. multi-GPU support: Add test for all policies (#6782) (details)
  10. Implement sort_by_key (#6801) (details)
  11. Fix scorecard workflow (#6831) (details)
  12. Remove redundant RangePolicy constructor (#6841) (details)
  13. Bump Google Benchmark version v1.{6.2 -> 7.1} in CMake FetchContent (details)
  14. Remove variadic range policy constructor (#6845) (details)
  15. Avoid unused variable warning in TestRangePolicyCTAD.cpp (details)
  16. Make Host backends be included before device backends (details)
  17. Add Grace CPU architecture (details)
  18. Add option to enable CUDA unified memory architectures (details)
  19. Fix tests for Unified Memory option being on (details)
  20. Apply suggestions from code review (details)
  21. Print configuration for UNIFIED_MEMORY (details)
Commit 37962b3d2f9a26ce3fdcb80229ab3a73106f456b by Daniel Arndt
SYCL: Cleanup device selection
The file was modified core/src/SYCL/Kokkos_SYCL.cpp (diff)
Commit df68761f97725144a6ad612c8b44186685e55cf2 by Daniel Arndt
SYCL CI: Avoid setvars.sh
The file was modified .jenkins (diff)
The file was modified scripts/docker/Dockerfile.sycl (diff)
Commit c3f0a2698327fbbc25a1f26674b8f60ae9eb701b by Daniel Arndt
Cleanup KOKKOS_CONFIGURE_CORE
The file was modified core/src/Kokkos_Core.hpp (diff)
The file was modified cmake/kokkos_tribits.cmake (diff)
The file was modified Makefile.kokkos (diff)
Commit 1112e07ebc3194355a7ae9766a91f54d2759f059 by Daniel Arndt
Update GitHub actions ot use Node 20
The file was modified .github/workflows/windows.yml (diff)
The file was modified .github/workflows/performance-benchmark.yml (diff)
The file was modified .github/workflows/clang-format-check.yml (diff)
The file was modified .github/workflows/continuous-integration-workflow-hpx.yml (diff)
The file was modified .github/workflows/continuous-integration-workflow.yml (diff)
The file was modified .github/workflows/continuous-integration-workflow-32bit.yml (diff)
The file was modified .github/workflows/osx.yml (diff)
Commit 361bdbf49e0093945950e1450c296b7906d76c0b by ndellin
[4.2.01]: changelog update  (#6656)

* [ci skip] [4.2.01]: changelog update

* [ci skip] [4.2.01]: changelog update

* Update CHANGELOG.md

Co-authored-by: Damien L-G <dalg24+github@gmail.com>

* Update CHANGELOG.md

Co-authored-by: Damien L-G <dalg24+github@gmail.com>

* Update CHANGELOG.md

Co-authored-by: Damien L-G <dalg24+github@gmail.com>

* Update CHANGELOG.md

Address review comments
- Add missing item for MSVC CUDA build fixes
- Drop item unnecessary for changelog

* Update changelog

* Update changelog

* [ci skip] Update patch version for 4.2.01

* Apply suggestions from code review

---------

Co-authored-by: Nathan Ellingwood <ndellin@sandia.gov>
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
The file was modified CHANGELOG.md (diff)
Commit 9d33cb7725943e048e150f7c9c58473ba98622e5 by noreply
Clean up shift_{right, left}_team_impl (#6821)

* Clean up shift_right_team_impl

* Update shift_left_team_impl for consistency
The file was modified algorithms/src/std_algorithms/impl/Kokkos_ShiftLeft.hpp (diff)
The file was modified algorithms/src/std_algorithms/impl/Kokkos_ShiftRight.hpp (diff)
Commit e2c810e1f213a09bce152eba623b7f275c035ec8 by Daniel Arndt
Avoid detecting unwanted fences in the parallel_scan_no_fence test
The file was modified core/unit_test/tools/TestEventCorrectness.hpp (diff)
Commit 24f251a854b36c13804e1ac850e8ae2a9e2bcdac by noreply
Add test for current CTAD support with RangePolicy (#6803)

* Add test for current CTAD support with RangePolicy

Co-authored-by: Nevin Liber <nliber@anl.gov>

* Rework CTAD test to avoid "memeber <bla> was declared but never referenced" warnings with icpc 19

* Attempt to fix CI

* Attempt to eliminate maybe unused warning in icpc

* Disable CTAD tests for nvcc < 11.2
as compiler bugs prevent CTAD expressions inside decltype

---------

Co-authored-by: Nevin Liber <nliber@anl.gov>
Co-authored-by: Nevin ":-)" Liber <nliber+github@gmail.com>
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was addedcore/unit_test/TestRangePolicyCTAD.cpp
Commit 16a5ebe95e88bf103ff7459ca1b1ce9983426eed by noreply
multi-GPU support: Add test for all policies (#6782)

* Cuda multi-GPU support: Test with managed and unmanaged Views

* Move check for cuda_device

* Also test copying between devices

* Refactor using StreamsAndDevices

* Don't use shared_ptr
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was modified core/unit_test/cuda/TestCuda_InterOp_StreamsMultiGPU.cpp (diff)
Commit c90a9c6f7bf439b4e224a0eaabcc2af815980dc5 by noreply
Implement sort_by_key (#6801)

* Implement sort_by_key

* Address review comments

* Make passed in view const ref

* Fix _via_sort for OpenMPTarget

Co-authored-by: Daniel Arndt <arndtd@ornl.gov>

* Rip out ROCThrust for now

* Few changes to address the comments

* Fix SYCL

* Fix SYCL implementation

---------

Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
The file was modified algorithms/unit_tests/CMakeLists.txt (diff)
The file was addedalgorithms/unit_tests/TestSortByKey.hpp
The file was addedalgorithms/src/sorting/Kokkos_SortByKeyPublicAPI.hpp
The file was modified algorithms/src/Kokkos_Sort.hpp (diff)
The file was addedalgorithms/src/sorting/impl/Kokkos_SortByKeyImpl.hpp
Commit 058c3a08e6b871f2ddfe3774f390ee473525df5e by noreply
Fix scorecard workflow (#6831)

* Add Scorecrad

* another one

* Don't run on pull requests

* Add comments back in
The file was modified .github/workflows/scorecard.yml (diff)
Commit 04a5334c699cb9b87293d27bc73090b3b7c13019 by noreply
Remove redundant RangePolicy constructor (#6841)

* Remove redundant RangePolicy constructor

* Disable test case for Cuda <11.2 completely
The file was modified core/unit_test/TestRangePolicyCTAD.cpp (diff)
The file was modified core/src/Kokkos_ExecPolicy.hpp (diff)
Commit 0cdc9eb768582bec4af8f0e44057e235ca8277f0 by Damien L-G
Bump Google Benchmark version v1.{6.2 -> 7.1} in CMake FetchContent
The file was modified core/perf_test/CMakeLists.txt (diff)
Commit 8b8de2cf47cd85005b6adafb8fe5c99b57c32c23 by noreply
Remove variadic range policy constructor (#6845)

* Removed variadic ctor from RangePolicy, as well as extra
set(...) methods.

* In RangePolicy:
Deprecated set(ChunkSize)
In the ctor that takes a ChunkSize, set the chunk size via
set_chunk_size instead of via member initializers (to be more consistent
with other code)

* Removed superfluous "inline" from two of the RangePolicy constructors
The file was modified core/src/Kokkos_ExecPolicy.hpp (diff)
Commit dc524910d397feb7050b39f34d38dfd7d4f82b65 by Daniel Arndt
Avoid unused variable warning in TestRangePolicyCTAD.cpp
The file was modified core/unit_test/TestRangePolicyCTAD.cpp (diff)
Commit dc5010002e6b1a11d98bfe6290a12b654e25673b by crtrott
Make Host backends be included before device backends

There was an inclusion order issue when trying to enable
unified memory, which was due to incomplete types.
Effectively the Host backends must be defined before
the device memory spaces for them to be marked accessible.

We may have the same issue if we try to mark HostSpace accessible
by device memory spaces - but I am not sure.
The file was modified cmake/kokkos_enable_devices.cmake (diff)
The file was modified Makefile.kokkos (diff)
Commit 7899413e4b4e17d424ae8fad23e262f545dab16b by crtrott
Add Grace CPU architecture
The file was modified cmake/kokkos_arch.cmake (diff)
The file was modified Makefile.kokkos (diff)
Commit f24357e8a050e04235b5cbd5da49d7c14aff2fae by crtrott
Add option to enable CUDA unified memory architectures

This is in support of Grace Hopper making, CudaSpace host accessible.
I also added an emulation mode to run on other CUDA architectures,
by making the cudaMalloc wrapper call cudaMallocManaged.

Kokkos_ENABLE_IMPL_CUDA_EMULATE_UNIFIED_MEMORY is the option

A new macro KOKKOS_ENABLE_IMPL_CUDA_UNIFIED_MEMORY will be defined
if both Grace and Hopper are enabled.
The file was modified core/src/Kokkos_Macros.hpp (diff)
The file was modified cmake/kokkos_enable_options.cmake (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.hpp (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.hpp (diff)
The file was modified cmake/KokkosCore_config.h.in (diff)
Commit f433545e6c6ba8aa8344c5c734700352f8cd8931 by crtrott
Fix tests for Unified Memory option being on
The file was modified containers/unit_tests/TestWithoutInitializing.hpp (diff)
The file was modified core/unit_test/cuda/TestCuda_Spaces.cpp (diff)
Commit 963bbf808932615fc1ee5dddc250bf9e3c0d32d5 by crtrott
Apply suggestions from code review

Co-authored-by: Damien L-G <dalg24+github@gmail.com>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.hpp (diff)
The file was modified Makefile.kokkos (diff)
The file was modified containers/unit_tests/TestWithoutInitializing.hpp (diff)
The file was modified cmake/kokkos_enable_devices.cmake (diff)
The file was modified core/unit_test/cuda/TestCuda_Spaces.cpp (diff)
Commit 0a9ff6c31ba8e6c714d30ba0e780f15ebdac4ce2 by crtrott
Print configuration for UNIFIED_MEMORY
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.cpp (diff)

Summary

  1. SYCL: Cleanup device selection (details)
  2. SYCL CI: Avoid setvars.sh (details)
  3. Cleanup KOKKOS_CONFIGURE_CORE (details)
  4. Update GitHub actions ot use Node 20 (details)
  5. [4.2.01]: changelog update  (#6656) (details)
  6. Clean up shift_{right, left}_team_impl (#6821) (details)
  7. Avoid detecting unwanted fences in the parallel_scan_no_fence test (details)
  8. Add test for current CTAD support with RangePolicy (#6803) (details)
  9. multi-GPU support: Add test for all policies (#6782) (details)
  10. Implement sort_by_key (#6801) (details)
  11. Fix scorecard workflow (#6831) (details)
  12. Remove redundant RangePolicy constructor (#6841) (details)
  13. Bump Google Benchmark version v1.{6.2 -> 7.1} in CMake FetchContent (details)
  14. Remove variadic range policy constructor (#6845) (details)
  15. Avoid unused variable warning in TestRangePolicyCTAD.cpp (details)
  16. Make Host backends be included before device backends (details)
  17. Add Grace CPU architecture (details)
  18. Add option to enable CUDA unified memory architectures (details)
  19. Fix tests for Unified Memory option being on (details)
  20. Apply suggestions from code review (details)
  21. Print configuration for UNIFIED_MEMORY (details)
Commit 37962b3d2f9a26ce3fdcb80229ab3a73106f456b by Daniel Arndt
SYCL: Cleanup device selection
The file was modified core/src/SYCL/Kokkos_SYCL.cpp (diff)
Commit df68761f97725144a6ad612c8b44186685e55cf2 by Daniel Arndt
SYCL CI: Avoid setvars.sh
The file was modified scripts/docker/Dockerfile.sycl (diff)
The file was modified .jenkins (diff)
Commit c3f0a2698327fbbc25a1f26674b8f60ae9eb701b by Daniel Arndt
Cleanup KOKKOS_CONFIGURE_CORE
The file was modified core/src/Kokkos_Core.hpp (diff)
The file was modified cmake/kokkos_tribits.cmake (diff)
The file was modified Makefile.kokkos (diff)
Commit 1112e07ebc3194355a7ae9766a91f54d2759f059 by Daniel Arndt
Update GitHub actions ot use Node 20
The file was modified .github/workflows/windows.yml (diff)
The file was modified .github/workflows/osx.yml (diff)
The file was modified .github/workflows/performance-benchmark.yml (diff)
The file was modified .github/workflows/continuous-integration-workflow-32bit.yml (diff)
The file was modified .github/workflows/clang-format-check.yml (diff)
The file was modified .github/workflows/continuous-integration-workflow.yml (diff)
The file was modified .github/workflows/continuous-integration-workflow-hpx.yml (diff)
Commit 361bdbf49e0093945950e1450c296b7906d76c0b by ndellin
[4.2.01]: changelog update  (#6656)

* [ci skip] [4.2.01]: changelog update

* [ci skip] [4.2.01]: changelog update

* Update CHANGELOG.md

Co-authored-by: Damien L-G <dalg24+github@gmail.com>

* Update CHANGELOG.md

Co-authored-by: Damien L-G <dalg24+github@gmail.com>

* Update CHANGELOG.md

Co-authored-by: Damien L-G <dalg24+github@gmail.com>

* Update CHANGELOG.md

Address review comments
- Add missing item for MSVC CUDA build fixes
- Drop item unnecessary for changelog

* Update changelog

* Update changelog

* [ci skip] Update patch version for 4.2.01

* Apply suggestions from code review

---------

Co-authored-by: Nathan Ellingwood <ndellin@sandia.gov>
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
The file was modified CHANGELOG.md (diff)
Commit 9d33cb7725943e048e150f7c9c58473ba98622e5 by noreply
Clean up shift_{right, left}_team_impl (#6821)

* Clean up shift_right_team_impl

* Update shift_left_team_impl for consistency
The file was modified algorithms/src/std_algorithms/impl/Kokkos_ShiftLeft.hpp (diff)
The file was modified algorithms/src/std_algorithms/impl/Kokkos_ShiftRight.hpp (diff)
Commit e2c810e1f213a09bce152eba623b7f275c035ec8 by Daniel Arndt
Avoid detecting unwanted fences in the parallel_scan_no_fence test
The file was modified core/unit_test/tools/TestEventCorrectness.hpp (diff)
Commit 24f251a854b36c13804e1ac850e8ae2a9e2bcdac by noreply
Add test for current CTAD support with RangePolicy (#6803)

* Add test for current CTAD support with RangePolicy

Co-authored-by: Nevin Liber <nliber@anl.gov>

* Rework CTAD test to avoid "memeber <bla> was declared but never referenced" warnings with icpc 19

* Attempt to fix CI

* Attempt to eliminate maybe unused warning in icpc

* Disable CTAD tests for nvcc < 11.2
as compiler bugs prevent CTAD expressions inside decltype

---------

Co-authored-by: Nevin Liber <nliber@anl.gov>
Co-authored-by: Nevin ":-)" Liber <nliber+github@gmail.com>
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was addedcore/unit_test/TestRangePolicyCTAD.cpp
Commit 16a5ebe95e88bf103ff7459ca1b1ce9983426eed by noreply
multi-GPU support: Add test for all policies (#6782)

* Cuda multi-GPU support: Test with managed and unmanaged Views

* Move check for cuda_device

* Also test copying between devices

* Refactor using StreamsAndDevices

* Don't use shared_ptr
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was modified core/unit_test/cuda/TestCuda_InterOp_StreamsMultiGPU.cpp (diff)
Commit c90a9c6f7bf439b4e224a0eaabcc2af815980dc5 by noreply
Implement sort_by_key (#6801)

* Implement sort_by_key

* Address review comments

* Make passed in view const ref

* Fix _via_sort for OpenMPTarget

Co-authored-by: Daniel Arndt <arndtd@ornl.gov>

* Rip out ROCThrust for now

* Few changes to address the comments

* Fix SYCL

* Fix SYCL implementation

---------

Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
The file was modified algorithms/src/Kokkos_Sort.hpp (diff)
The file was addedalgorithms/src/sorting/impl/Kokkos_SortByKeyImpl.hpp
The file was addedalgorithms/unit_tests/TestSortByKey.hpp
The file was addedalgorithms/src/sorting/Kokkos_SortByKeyPublicAPI.hpp
The file was modified algorithms/unit_tests/CMakeLists.txt (diff)
Commit 058c3a08e6b871f2ddfe3774f390ee473525df5e by noreply
Fix scorecard workflow (#6831)

* Add Scorecrad

* another one

* Don't run on pull requests

* Add comments back in
The file was modified .github/workflows/scorecard.yml (diff)
Commit 04a5334c699cb9b87293d27bc73090b3b7c13019 by noreply
Remove redundant RangePolicy constructor (#6841)

* Remove redundant RangePolicy constructor

* Disable test case for Cuda <11.2 completely
The file was modified core/src/Kokkos_ExecPolicy.hpp (diff)
The file was modified core/unit_test/TestRangePolicyCTAD.cpp (diff)
Commit 0cdc9eb768582bec4af8f0e44057e235ca8277f0 by Damien L-G
Bump Google Benchmark version v1.{6.2 -> 7.1} in CMake FetchContent
The file was modified core/perf_test/CMakeLists.txt (diff)
Commit 8b8de2cf47cd85005b6adafb8fe5c99b57c32c23 by noreply
Remove variadic range policy constructor (#6845)

* Removed variadic ctor from RangePolicy, as well as extra
set(...) methods.

* In RangePolicy:
Deprecated set(ChunkSize)
In the ctor that takes a ChunkSize, set the chunk size via
set_chunk_size instead of via member initializers (to be more consistent
with other code)

* Removed superfluous "inline" from two of the RangePolicy constructors
The file was modified core/src/Kokkos_ExecPolicy.hpp (diff)
Commit dc524910d397feb7050b39f34d38dfd7d4f82b65 by Daniel Arndt
Avoid unused variable warning in TestRangePolicyCTAD.cpp
The file was modified core/unit_test/TestRangePolicyCTAD.cpp (diff)
Commit dc5010002e6b1a11d98bfe6290a12b654e25673b by crtrott
Make Host backends be included before device backends

There was an inclusion order issue when trying to enable
unified memory, which was due to incomplete types.
Effectively the Host backends must be defined before
the device memory spaces for them to be marked accessible.

We may have the same issue if we try to mark HostSpace accessible
by device memory spaces - but I am not sure.
The file was modified Makefile.kokkos (diff)
The file was modified cmake/kokkos_enable_devices.cmake (diff)
Commit 7899413e4b4e17d424ae8fad23e262f545dab16b by crtrott
Add Grace CPU architecture
The file was modified cmake/kokkos_arch.cmake (diff)
The file was modified Makefile.kokkos (diff)
Commit f24357e8a050e04235b5cbd5da49d7c14aff2fae by crtrott
Add option to enable CUDA unified memory architectures

This is in support of Grace Hopper making, CudaSpace host accessible.
I also added an emulation mode to run on other CUDA architectures,
by making the cudaMalloc wrapper call cudaMallocManaged.

Kokkos_ENABLE_IMPL_CUDA_EMULATE_UNIFIED_MEMORY is the option

A new macro KOKKOS_ENABLE_IMPL_CUDA_UNIFIED_MEMORY will be defined
if both Grace and Hopper are enabled.
The file was modified cmake/KokkosCore_config.h.in (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.hpp (diff)
The file was modified cmake/kokkos_enable_options.cmake (diff)
The file was modified core/src/Kokkos_Macros.hpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.hpp (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
Commit f433545e6c6ba8aa8344c5c734700352f8cd8931 by crtrott
Fix tests for Unified Memory option being on
The file was modified core/unit_test/cuda/TestCuda_Spaces.cpp (diff)
The file was modified containers/unit_tests/TestWithoutInitializing.hpp (diff)
Commit 963bbf808932615fc1ee5dddc250bf9e3c0d32d5 by crtrott
Apply suggestions from code review

Co-authored-by: Damien L-G <dalg24+github@gmail.com>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
The file was modified containers/unit_tests/TestWithoutInitializing.hpp (diff)
The file was modified Makefile.kokkos (diff)
The file was modified cmake/kokkos_enable_devices.cmake (diff)
The file was modified core/unit_test/cuda/TestCuda_Spaces.cpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.hpp (diff)
Commit 0a9ff6c31ba8e6c714d30ba0e780f15ebdac4ce2 by crtrott
Print configuration for UNIFIED_MEMORY
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.cpp (diff)