Skip to content
Failed

Changes

Summary

  1. Avoid calling wrapper functions with singleton in some classes (details)
  2. Deprecate `in_parallel` (#6032) (#6582) (details)
  3. Remove redundant calls in rangepolicy constructors (#6765) (details)
Commit a082f820d557cdd4921cd893ba0c54d0fe7a211b by Daniel Arndt
Avoid calling wrapper functions with singleton in some classes
The file was modified core/src/Cuda/Kokkos_Cuda_Error.hpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.cpp (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
Commit 71b246d674600c7f83bc553f3ce5fe7dd6216d2b by noreply
Deprecate `in_parallel` (#6032) (#6582)

* in_parallel: rebase on upstream/develop, resolve conflicts, clang-formatting

* rebase on upstream/develop, resolve conflicts, clang format

* Apply clang-formatting (clang-8.0.1), mv execute_in_serial function

* OpenMP fixes, clang-8 formatting

* Kokkos_OpenMP_Instance.hpp: add ";" to end of class definition

* Address round 3 of DA comments

* Fix typos in deprecation markings

* Fix CI failures in OpenACC, OpenMP, Threads backends

* rm conditional statement

* rm additional `in_parallel` statements

* Correctly flag namespace brace

* Address most recent DA comments

* rm brace at 3108

* rm else branch; change "==" to "=" in TestExecutionSpace

* Add deprecation marking for all `in_parallel`-requiring tests

* TestHPX_InParallel.cpp: rm unused variable "n"

* TestHPX_InParallel.cpp: put "n" inside of Deprecaton marking

* Add dep. marking to `impl_in_parallel_scope`-type statements

* Add deprecation marking to all impl_not_in_parallel_scope

* Address DLG comments

* rm errant "e += i"

* rm second definition of "execute_in_serial"

* Address DA comments

* Fix up function call operator

* Addressing final DA comments

* Apply deprecation markings uniformly

* Put deprecation markings around braced clauses

* Apply suggestions from review

---------

Co-authored-by: Damien L-G <dalg24@gmail.com>
The file was modified core/src/OpenACC/Kokkos_OpenACC.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP_Instance.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.cpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.cpp (diff)
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was modified core/src/Cuda/Kokkos_Cuda.hpp (diff)
The file was modified core/src/OpenMPTarget/Kokkos_OpenMPTarget.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)
The file was modified core/unit_test/TestExecutionSpace.hpp (diff)
The file was modified core/unit_test/incremental/Test01_execspace.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads.hpp (diff)
The file was modified core/src/HIP/Kokkos_HIP.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.cpp (diff)
Commit bbb895a347f4c511a9fc85193ca554f105e99739 by noreply
Remove redundant calls in rangepolicy constructors (#6765)

* Removed redudant calls from RangePolicy constructors

* Fixed to call the right constructor
The file was modified core/src/Kokkos_ExecPolicy.hpp (diff)

Summary

  1. Avoid calling wrapper functions with singleton in some classes (details)
  2. Deprecate `in_parallel` (#6032) (#6582) (details)
  3. Remove redundant calls in rangepolicy constructors (#6765) (details)
Commit a082f820d557cdd4921cd893ba0c54d0fe7a211b by Daniel Arndt
Avoid calling wrapper functions with singleton in some classes
The file was modified core/src/Cuda/Kokkos_Cuda_Error.hpp (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.cpp (diff)
Commit 71b246d674600c7f83bc553f3ce5fe7dd6216d2b by noreply
Deprecate `in_parallel` (#6032) (#6582)

* in_parallel: rebase on upstream/develop, resolve conflicts, clang-formatting

* rebase on upstream/develop, resolve conflicts, clang format

* Apply clang-formatting (clang-8.0.1), mv execute_in_serial function

* OpenMP fixes, clang-8 formatting

* Kokkos_OpenMP_Instance.hpp: add ";" to end of class definition

* Address round 3 of DA comments

* Fix typos in deprecation markings

* Fix CI failures in OpenACC, OpenMP, Threads backends

* rm conditional statement

* rm additional `in_parallel` statements

* Correctly flag namespace brace

* Address most recent DA comments

* rm brace at 3108

* rm else branch; change "==" to "=" in TestExecutionSpace

* Add deprecation marking for all `in_parallel`-requiring tests

* TestHPX_InParallel.cpp: rm unused variable "n"

* TestHPX_InParallel.cpp: put "n" inside of Deprecaton marking

* Add dep. marking to `impl_in_parallel_scope`-type statements

* Add deprecation marking to all impl_not_in_parallel_scope

* Address DLG comments

* rm errant "e += i"

* rm second definition of "execute_in_serial"

* Address DA comments

* Fix up function call operator

* Addressing final DA comments

* Apply deprecation markings uniformly

* Put deprecation markings around braced clauses

* Apply suggestions from review

---------

Co-authored-by: Damien L-G <dalg24@gmail.com>
The file was modified core/src/Cuda/Kokkos_Cuda.hpp (diff)
The file was modified core/src/OpenACC/Kokkos_OpenACC.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.cpp (diff)
The file was modified core/src/HIP/Kokkos_HIP.hpp (diff)
The file was modified core/unit_test/incremental/Test01_execspace.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.cpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP_Instance.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.hpp (diff)
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was modified core/unit_test/TestExecutionSpace.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.hpp (diff)
The file was modified core/src/OpenMPTarget/Kokkos_OpenMPTarget.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.cpp (diff)
Commit bbb895a347f4c511a9fc85193ca554f105e99739 by noreply
Remove redundant calls in rangepolicy constructors (#6765)

* Removed redudant calls from RangePolicy constructors

* Fixed to call the right constructor
The file was modified core/src/Kokkos_ExecPolicy.hpp (diff)

Summary

  1. Avoid calling wrapper functions with singleton in some classes (details)
  2. Deprecate `in_parallel` (#6032) (#6582) (details)
  3. Remove redundant calls in rangepolicy constructors (#6765) (details)
Commit a082f820d557cdd4921cd893ba0c54d0fe7a211b by Daniel Arndt
Avoid calling wrapper functions with singleton in some classes
The file was modified core/src/Cuda/Kokkos_Cuda_Error.hpp (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.cpp (diff)
Commit 71b246d674600c7f83bc553f3ce5fe7dd6216d2b by noreply
Deprecate `in_parallel` (#6032) (#6582)

* in_parallel: rebase on upstream/develop, resolve conflicts, clang-formatting

* rebase on upstream/develop, resolve conflicts, clang format

* Apply clang-formatting (clang-8.0.1), mv execute_in_serial function

* OpenMP fixes, clang-8 formatting

* Kokkos_OpenMP_Instance.hpp: add ";" to end of class definition

* Address round 3 of DA comments

* Fix typos in deprecation markings

* Fix CI failures in OpenACC, OpenMP, Threads backends

* rm conditional statement

* rm additional `in_parallel` statements

* Correctly flag namespace brace

* Address most recent DA comments

* rm brace at 3108

* rm else branch; change "==" to "=" in TestExecutionSpace

* Add deprecation marking for all `in_parallel`-requiring tests

* TestHPX_InParallel.cpp: rm unused variable "n"

* TestHPX_InParallel.cpp: put "n" inside of Deprecaton marking

* Add dep. marking to `impl_in_parallel_scope`-type statements

* Add deprecation marking to all impl_not_in_parallel_scope

* Address DLG comments

* rm errant "e += i"

* rm second definition of "execute_in_serial"

* Address DA comments

* Fix up function call operator

* Addressing final DA comments

* Apply deprecation markings uniformly

* Put deprecation markings around braced clauses

* Apply suggestions from review

---------

Co-authored-by: Damien L-G <dalg24@gmail.com>
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.cpp (diff)
The file was modified core/unit_test/TestExecutionSpace.hpp (diff)
The file was modified core/unit_test/incremental/Test01_execspace.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads.hpp (diff)
The file was modified core/src/OpenACC/Kokkos_OpenACC.hpp (diff)
The file was modified core/src/HIP/Kokkos_HIP.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.cpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP_Instance.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.hpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.hpp (diff)
The file was modified core/src/OpenMPTarget/Kokkos_OpenMPTarget.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.cpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
Commit bbb895a347f4c511a9fc85193ca554f105e99739 by noreply
Remove redundant calls in rangepolicy constructors (#6765)

* Removed redudant calls from RangePolicy constructors

* Fixed to call the right constructor
The file was modified core/src/Kokkos_ExecPolicy.hpp (diff)

Summary

  1. Avoid calling wrapper functions with singleton in some classes (details)
  2. Deprecate `in_parallel` (#6032) (#6582) (details)
  3. Remove redundant calls in rangepolicy constructors (#6765) (details)
Commit a082f820d557cdd4921cd893ba0c54d0fe7a211b by Daniel Arndt
Avoid calling wrapper functions with singleton in some classes
The file was modified core/src/Cuda/Kokkos_Cuda_Error.hpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.cpp (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
Commit 71b246d674600c7f83bc553f3ce5fe7dd6216d2b by noreply
Deprecate `in_parallel` (#6032) (#6582)

* in_parallel: rebase on upstream/develop, resolve conflicts, clang-formatting

* rebase on upstream/develop, resolve conflicts, clang format

* Apply clang-formatting (clang-8.0.1), mv execute_in_serial function

* OpenMP fixes, clang-8 formatting

* Kokkos_OpenMP_Instance.hpp: add ";" to end of class definition

* Address round 3 of DA comments

* Fix typos in deprecation markings

* Fix CI failures in OpenACC, OpenMP, Threads backends

* rm conditional statement

* rm additional `in_parallel` statements

* Correctly flag namespace brace

* Address most recent DA comments

* rm brace at 3108

* rm else branch; change "==" to "=" in TestExecutionSpace

* Add deprecation marking for all `in_parallel`-requiring tests

* TestHPX_InParallel.cpp: rm unused variable "n"

* TestHPX_InParallel.cpp: put "n" inside of Deprecaton marking

* Add dep. marking to `impl_in_parallel_scope`-type statements

* Add deprecation marking to all impl_not_in_parallel_scope

* Address DLG comments

* rm errant "e += i"

* rm second definition of "execute_in_serial"

* Address DA comments

* Fix up function call operator

* Addressing final DA comments

* Apply deprecation markings uniformly

* Put deprecation markings around braced clauses

* Apply suggestions from review

---------

Co-authored-by: Damien L-G <dalg24@gmail.com>
The file was modified core/src/SYCL/Kokkos_SYCL.hpp (diff)
The file was modified core/src/OpenMPTarget/Kokkos_OpenMPTarget.hpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)
The file was modified core/src/HIP/Kokkos_HIP.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP_Instance.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.cpp (diff)
The file was modified core/src/OpenACC/Kokkos_OpenACC.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.cpp (diff)
The file was modified core/unit_test/incremental/Test01_execspace.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.cpp (diff)
The file was modified core/unit_test/TestExecutionSpace.hpp (diff)
The file was modified core/unit_test/CMakeLists.txt (diff)
Commit bbb895a347f4c511a9fc85193ca554f105e99739 by noreply
Remove redundant calls in rangepolicy constructors (#6765)

* Removed redudant calls from RangePolicy constructors

* Fixed to call the right constructor
The file was modified core/src/Kokkos_ExecPolicy.hpp (diff)

Summary

  1. Avoid calling wrapper functions with singleton in some classes (details)
  2. Deprecate `in_parallel` (#6032) (#6582) (details)
  3. Remove redundant calls in rangepolicy constructors (#6765) (details)
Commit a082f820d557cdd4921cd893ba0c54d0fe7a211b by Daniel Arndt
Avoid calling wrapper functions with singleton in some classes
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.cpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Error.hpp (diff)
Commit 71b246d674600c7f83bc553f3ce5fe7dd6216d2b by noreply
Deprecate `in_parallel` (#6032) (#6582)

* in_parallel: rebase on upstream/develop, resolve conflicts, clang-formatting

* rebase on upstream/develop, resolve conflicts, clang format

* Apply clang-formatting (clang-8.0.1), mv execute_in_serial function

* OpenMP fixes, clang-8 formatting

* Kokkos_OpenMP_Instance.hpp: add ";" to end of class definition

* Address round 3 of DA comments

* Fix typos in deprecation markings

* Fix CI failures in OpenACC, OpenMP, Threads backends

* rm conditional statement

* rm additional `in_parallel` statements

* Correctly flag namespace brace

* Address most recent DA comments

* rm brace at 3108

* rm else branch; change "==" to "=" in TestExecutionSpace

* Add deprecation marking for all `in_parallel`-requiring tests

* TestHPX_InParallel.cpp: rm unused variable "n"

* TestHPX_InParallel.cpp: put "n" inside of Deprecaton marking

* Add dep. marking to `impl_in_parallel_scope`-type statements

* Add deprecation marking to all impl_not_in_parallel_scope

* Address DLG comments

* rm errant "e += i"

* rm second definition of "execute_in_serial"

* Address DA comments

* Fix up function call operator

* Addressing final DA comments

* Apply deprecation markings uniformly

* Put deprecation markings around braced clauses

* Apply suggestions from review

---------

Co-authored-by: Damien L-G <dalg24@gmail.com>
The file was modified core/src/Cuda/Kokkos_Cuda.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL.hpp (diff)
The file was modified core/src/HIP/Kokkos_HIP.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.cpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.cpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.cpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP_Instance.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads.hpp (diff)
The file was modified core/src/OpenACC/Kokkos_OpenACC.hpp (diff)
The file was modified core/src/OpenMPTarget/Kokkos_OpenMPTarget.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.hpp (diff)
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was modified core/src/HPX/Kokkos_HPX.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
The file was modified core/unit_test/incremental/Test01_execspace.hpp (diff)
The file was modified core/unit_test/TestExecutionSpace.hpp (diff)
Commit bbb895a347f4c511a9fc85193ca554f105e99739 by noreply
Remove redundant calls in rangepolicy constructors (#6765)

* Removed redudant calls from RangePolicy constructors

* Fixed to call the right constructor
The file was modified core/src/Kokkos_ExecPolicy.hpp (diff)

Summary

  1. Avoid calling wrapper functions with singleton in some classes (details)
  2. Deprecate `in_parallel` (#6032) (#6582) (details)
  3. Remove redundant calls in rangepolicy constructors (#6765) (details)
Commit a082f820d557cdd4921cd893ba0c54d0fe7a211b by Daniel Arndt
Avoid calling wrapper functions with singleton in some classes
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.cpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Error.hpp (diff)
Commit 71b246d674600c7f83bc553f3ce5fe7dd6216d2b by noreply
Deprecate `in_parallel` (#6032) (#6582)

* in_parallel: rebase on upstream/develop, resolve conflicts, clang-formatting

* rebase on upstream/develop, resolve conflicts, clang format

* Apply clang-formatting (clang-8.0.1), mv execute_in_serial function

* OpenMP fixes, clang-8 formatting

* Kokkos_OpenMP_Instance.hpp: add ";" to end of class definition

* Address round 3 of DA comments

* Fix typos in deprecation markings

* Fix CI failures in OpenACC, OpenMP, Threads backends

* rm conditional statement

* rm additional `in_parallel` statements

* Correctly flag namespace brace

* Address most recent DA comments

* rm brace at 3108

* rm else branch; change "==" to "=" in TestExecutionSpace

* Add deprecation marking for all `in_parallel`-requiring tests

* TestHPX_InParallel.cpp: rm unused variable "n"

* TestHPX_InParallel.cpp: put "n" inside of Deprecaton marking

* Add dep. marking to `impl_in_parallel_scope`-type statements

* Add deprecation marking to all impl_not_in_parallel_scope

* Address DLG comments

* rm errant "e += i"

* rm second definition of "execute_in_serial"

* Address DA comments

* Fix up function call operator

* Addressing final DA comments

* Apply deprecation markings uniformly

* Put deprecation markings around braced clauses

* Apply suggestions from review

---------

Co-authored-by: Damien L-G <dalg24@gmail.com>
The file was modified core/src/HIP/Kokkos_HIP.hpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda.hpp (diff)
The file was modified core/src/OpenACC/Kokkos_OpenACC.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL.hpp (diff)
The file was modified core/unit_test/incremental/Test01_execspace.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.cpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP_Instance.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.cpp (diff)
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.cpp (diff)
The file was modified core/src/OpenMPTarget/Kokkos_OpenMPTarget.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)
The file was modified core/unit_test/TestExecutionSpace.hpp (diff)
The file was modified core/unit_test/CMakeLists.txt (diff)
Commit bbb895a347f4c511a9fc85193ca554f105e99739 by noreply
Remove redundant calls in rangepolicy constructors (#6765)

* Removed redudant calls from RangePolicy constructors

* Fixed to call the right constructor
The file was modified core/src/Kokkos_ExecPolicy.hpp (diff)

Summary

  1. Avoid calling wrapper functions with singleton in some classes (details)
  2. Deprecate `in_parallel` (#6032) (#6582) (details)
  3. Remove redundant calls in rangepolicy constructors (#6765) (details)
Commit a082f820d557cdd4921cd893ba0c54d0fe7a211b by Daniel Arndt
Avoid calling wrapper functions with singleton in some classes
The file was modified core/src/Cuda/Kokkos_Cuda_Error.hpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.cpp (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
Commit 71b246d674600c7f83bc553f3ce5fe7dd6216d2b by noreply
Deprecate `in_parallel` (#6032) (#6582)

* in_parallel: rebase on upstream/develop, resolve conflicts, clang-formatting

* rebase on upstream/develop, resolve conflicts, clang format

* Apply clang-formatting (clang-8.0.1), mv execute_in_serial function

* OpenMP fixes, clang-8 formatting

* Kokkos_OpenMP_Instance.hpp: add ";" to end of class definition

* Address round 3 of DA comments

* Fix typos in deprecation markings

* Fix CI failures in OpenACC, OpenMP, Threads backends

* rm conditional statement

* rm additional `in_parallel` statements

* Correctly flag namespace brace

* Address most recent DA comments

* rm brace at 3108

* rm else branch; change "==" to "=" in TestExecutionSpace

* Add deprecation marking for all `in_parallel`-requiring tests

* TestHPX_InParallel.cpp: rm unused variable "n"

* TestHPX_InParallel.cpp: put "n" inside of Deprecaton marking

* Add dep. marking to `impl_in_parallel_scope`-type statements

* Add deprecation marking to all impl_not_in_parallel_scope

* Address DLG comments

* rm errant "e += i"

* rm second definition of "execute_in_serial"

* Address DA comments

* Fix up function call operator

* Addressing final DA comments

* Apply deprecation markings uniformly

* Put deprecation markings around braced clauses

* Apply suggestions from review

---------

Co-authored-by: Damien L-G <dalg24@gmail.com>
The file was modified core/src/OpenMP/Kokkos_OpenMP.cpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP_Instance.hpp (diff)
The file was modified core/src/HIP/Kokkos_HIP.hpp (diff)
The file was modified core/src/OpenACC/Kokkos_OpenACC.hpp (diff)
The file was modified core/src/OpenMPTarget/Kokkos_OpenMPTarget.hpp (diff)
The file was modified core/unit_test/TestExecutionSpace.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.cpp (diff)
The file was modified core/unit_test/incremental/Test01_execspace.hpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was modified core/src/HPX/Kokkos_HPX.cpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.hpp (diff)
Commit bbb895a347f4c511a9fc85193ca554f105e99739 by noreply
Remove redundant calls in rangepolicy constructors (#6765)

* Removed redudant calls from RangePolicy constructors

* Fixed to call the right constructor
The file was modified core/src/Kokkos_ExecPolicy.hpp (diff)

Summary

  1. Avoid calling wrapper functions with singleton in some classes (details)
  2. Deprecate `in_parallel` (#6032) (#6582) (details)
  3. Remove redundant calls in rangepolicy constructors (#6765) (details)
Commit a082f820d557cdd4921cd893ba0c54d0fe7a211b by Daniel Arndt
Avoid calling wrapper functions with singleton in some classes
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Error.hpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.cpp (diff)
Commit 71b246d674600c7f83bc553f3ce5fe7dd6216d2b by noreply
Deprecate `in_parallel` (#6032) (#6582)

* in_parallel: rebase on upstream/develop, resolve conflicts, clang-formatting

* rebase on upstream/develop, resolve conflicts, clang format

* Apply clang-formatting (clang-8.0.1), mv execute_in_serial function

* OpenMP fixes, clang-8 formatting

* Kokkos_OpenMP_Instance.hpp: add ";" to end of class definition

* Address round 3 of DA comments

* Fix typos in deprecation markings

* Fix CI failures in OpenACC, OpenMP, Threads backends

* rm conditional statement

* rm additional `in_parallel` statements

* Correctly flag namespace brace

* Address most recent DA comments

* rm brace at 3108

* rm else branch; change "==" to "=" in TestExecutionSpace

* Add deprecation marking for all `in_parallel`-requiring tests

* TestHPX_InParallel.cpp: rm unused variable "n"

* TestHPX_InParallel.cpp: put "n" inside of Deprecaton marking

* Add dep. marking to `impl_in_parallel_scope`-type statements

* Add deprecation marking to all impl_not_in_parallel_scope

* Address DLG comments

* rm errant "e += i"

* rm second definition of "execute_in_serial"

* Address DA comments

* Fix up function call operator

* Addressing final DA comments

* Apply deprecation markings uniformly

* Put deprecation markings around braced clauses

* Apply suggestions from review

---------

Co-authored-by: Damien L-G <dalg24@gmail.com>
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was modified core/src/Threads/Kokkos_Threads.hpp (diff)
The file was modified core/src/OpenMPTarget/Kokkos_OpenMPTarget.hpp (diff)
The file was modified core/unit_test/incremental/Test01_execspace.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP_Instance.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)
The file was modified core/src/HIP/Kokkos_HIP.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.cpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL.hpp (diff)
The file was modified core/unit_test/TestExecutionSpace.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.cpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.hpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.hpp (diff)
The file was modified core/src/OpenACC/Kokkos_OpenACC.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.cpp (diff)
Commit bbb895a347f4c511a9fc85193ca554f105e99739 by noreply
Remove redundant calls in rangepolicy constructors (#6765)

* Removed redudant calls from RangePolicy constructors

* Fixed to call the right constructor
The file was modified core/src/Kokkos_ExecPolicy.hpp (diff)

Summary

  1. Avoid calling wrapper functions with singleton in some classes (details)
  2. Deprecate `in_parallel` (#6032) (#6582) (details)
  3. Remove redundant calls in rangepolicy constructors (#6765) (details)
Commit a082f820d557cdd4921cd893ba0c54d0fe7a211b by Daniel Arndt
Avoid calling wrapper functions with singleton in some classes
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Error.hpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.cpp (diff)
Commit 71b246d674600c7f83bc553f3ce5fe7dd6216d2b by noreply
Deprecate `in_parallel` (#6032) (#6582)

* in_parallel: rebase on upstream/develop, resolve conflicts, clang-formatting

* rebase on upstream/develop, resolve conflicts, clang format

* Apply clang-formatting (clang-8.0.1), mv execute_in_serial function

* OpenMP fixes, clang-8 formatting

* Kokkos_OpenMP_Instance.hpp: add ";" to end of class definition

* Address round 3 of DA comments

* Fix typos in deprecation markings

* Fix CI failures in OpenACC, OpenMP, Threads backends

* rm conditional statement

* rm additional `in_parallel` statements

* Correctly flag namespace brace

* Address most recent DA comments

* rm brace at 3108

* rm else branch; change "==" to "=" in TestExecutionSpace

* Add deprecation marking for all `in_parallel`-requiring tests

* TestHPX_InParallel.cpp: rm unused variable "n"

* TestHPX_InParallel.cpp: put "n" inside of Deprecaton marking

* Add dep. marking to `impl_in_parallel_scope`-type statements

* Add deprecation marking to all impl_not_in_parallel_scope

* Address DLG comments

* rm errant "e += i"

* rm second definition of "execute_in_serial"

* Address DA comments

* Fix up function call operator

* Addressing final DA comments

* Apply deprecation markings uniformly

* Put deprecation markings around braced clauses

* Apply suggestions from review

---------

Co-authored-by: Damien L-G <dalg24@gmail.com>
The file was modified core/src/OpenMP/Kokkos_OpenMP_Instance.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.cpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.cpp (diff)
The file was modified core/unit_test/incremental/Test01_execspace.hpp (diff)
The file was modified core/unit_test/TestExecutionSpace.hpp (diff)
The file was modified core/src/OpenACC/Kokkos_OpenACC.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.hpp (diff)
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was modified core/src/HIP/Kokkos_HIP.hpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda.hpp (diff)
The file was modified core/src/OpenMPTarget/Kokkos_OpenMPTarget.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.cpp (diff)
The file was modified core/src/Threads/Kokkos_Threads.hpp (diff)
Commit bbb895a347f4c511a9fc85193ca554f105e99739 by noreply
Remove redundant calls in rangepolicy constructors (#6765)

* Removed redudant calls from RangePolicy constructors

* Fixed to call the right constructor
The file was modified core/src/Kokkos_ExecPolicy.hpp (diff)

Summary

  1. Avoid calling wrapper functions with singleton in some classes (details)
  2. Deprecate `in_parallel` (#6032) (#6582) (details)
  3. Remove redundant calls in rangepolicy constructors (#6765) (details)
Commit a082f820d557cdd4921cd893ba0c54d0fe7a211b by Daniel Arndt
Avoid calling wrapper functions with singleton in some classes
The file was modified core/src/Cuda/Kokkos_Cuda_Error.hpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.cpp (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
Commit 71b246d674600c7f83bc553f3ce5fe7dd6216d2b by noreply
Deprecate `in_parallel` (#6032) (#6582)

* in_parallel: rebase on upstream/develop, resolve conflicts, clang-formatting

* rebase on upstream/develop, resolve conflicts, clang format

* Apply clang-formatting (clang-8.0.1), mv execute_in_serial function

* OpenMP fixes, clang-8 formatting

* Kokkos_OpenMP_Instance.hpp: add ";" to end of class definition

* Address round 3 of DA comments

* Fix typos in deprecation markings

* Fix CI failures in OpenACC, OpenMP, Threads backends

* rm conditional statement

* rm additional `in_parallel` statements

* Correctly flag namespace brace

* Address most recent DA comments

* rm brace at 3108

* rm else branch; change "==" to "=" in TestExecutionSpace

* Add deprecation marking for all `in_parallel`-requiring tests

* TestHPX_InParallel.cpp: rm unused variable "n"

* TestHPX_InParallel.cpp: put "n" inside of Deprecaton marking

* Add dep. marking to `impl_in_parallel_scope`-type statements

* Add deprecation marking to all impl_not_in_parallel_scope

* Address DLG comments

* rm errant "e += i"

* rm second definition of "execute_in_serial"

* Address DA comments

* Fix up function call operator

* Addressing final DA comments

* Apply deprecation markings uniformly

* Put deprecation markings around braced clauses

* Apply suggestions from review

---------

Co-authored-by: Damien L-G <dalg24@gmail.com>
The file was modified core/src/OpenMP/Kokkos_OpenMP_Instance.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.cpp (diff)
The file was modified core/unit_test/incremental/Test01_execspace.hpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda.hpp (diff)
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.hpp (diff)
The file was modified core/src/OpenMPTarget/Kokkos_OpenMPTarget.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.hpp (diff)
The file was modified core/src/HIP/Kokkos_HIP.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.cpp (diff)
The file was modified core/unit_test/TestExecutionSpace.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL.hpp (diff)
The file was modified core/src/OpenACC/Kokkos_OpenACC.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.cpp (diff)
The file was modified core/src/Threads/Kokkos_Threads.hpp (diff)
Commit bbb895a347f4c511a9fc85193ca554f105e99739 by noreply
Remove redundant calls in rangepolicy constructors (#6765)

* Removed redudant calls from RangePolicy constructors

* Fixed to call the right constructor
The file was modified core/src/Kokkos_ExecPolicy.hpp (diff)

Summary

  1. Avoid calling wrapper functions with singleton in some classes (details)
  2. Deprecate `in_parallel` (#6032) (#6582) (details)
  3. Remove redundant calls in rangepolicy constructors (#6765) (details)
Commit a082f820d557cdd4921cd893ba0c54d0fe7a211b by Daniel Arndt
Avoid calling wrapper functions with singleton in some classes
The file was modified core/src/Cuda/Kokkos_Cuda_Error.hpp (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.cpp (diff)
Commit 71b246d674600c7f83bc553f3ce5fe7dd6216d2b by noreply
Deprecate `in_parallel` (#6032) (#6582)

* in_parallel: rebase on upstream/develop, resolve conflicts, clang-formatting

* rebase on upstream/develop, resolve conflicts, clang format

* Apply clang-formatting (clang-8.0.1), mv execute_in_serial function

* OpenMP fixes, clang-8 formatting

* Kokkos_OpenMP_Instance.hpp: add ";" to end of class definition

* Address round 3 of DA comments

* Fix typos in deprecation markings

* Fix CI failures in OpenACC, OpenMP, Threads backends

* rm conditional statement

* rm additional `in_parallel` statements

* Correctly flag namespace brace

* Address most recent DA comments

* rm brace at 3108

* rm else branch; change "==" to "=" in TestExecutionSpace

* Add deprecation marking for all `in_parallel`-requiring tests

* TestHPX_InParallel.cpp: rm unused variable "n"

* TestHPX_InParallel.cpp: put "n" inside of Deprecaton marking

* Add dep. marking to `impl_in_parallel_scope`-type statements

* Add deprecation marking to all impl_not_in_parallel_scope

* Address DLG comments

* rm errant "e += i"

* rm second definition of "execute_in_serial"

* Address DA comments

* Fix up function call operator

* Addressing final DA comments

* Apply deprecation markings uniformly

* Put deprecation markings around braced clauses

* Apply suggestions from review

---------

Co-authored-by: Damien L-G <dalg24@gmail.com>
The file was modified core/src/HPX/Kokkos_HPX.hpp (diff)
The file was modified core/src/OpenACC/Kokkos_OpenACC.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP_Instance.hpp (diff)
The file was modified core/src/OpenMPTarget/Kokkos_OpenMPTarget.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.cpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.cpp (diff)
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.hpp (diff)
The file was modified core/unit_test/CMakeLists.txt (diff)
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)
The file was modified core/unit_test/TestExecutionSpace.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.cpp (diff)
The file was modified core/src/HIP/Kokkos_HIP.hpp (diff)
The file was modified core/unit_test/incremental/Test01_execspace.hpp (diff)
Commit bbb895a347f4c511a9fc85193ca554f105e99739 by noreply
Remove redundant calls in rangepolicy constructors (#6765)

* Removed redudant calls from RangePolicy constructors

* Fixed to call the right constructor
The file was modified core/src/Kokkos_ExecPolicy.hpp (diff)

Summary

  1. Avoid calling wrapper functions with singleton in some classes (details)
  2. Deprecate `in_parallel` (#6032) (#6582) (details)
  3. Remove redundant calls in rangepolicy constructors (#6765) (details)
Commit a082f820d557cdd4921cd893ba0c54d0fe7a211b by Daniel Arndt
Avoid calling wrapper functions with singleton in some classes
The file was modified core/src/Cuda/Kokkos_Cuda_Instance.cpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda_Error.hpp (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
Commit 71b246d674600c7f83bc553f3ce5fe7dd6216d2b by noreply
Deprecate `in_parallel` (#6032) (#6582)

* in_parallel: rebase on upstream/develop, resolve conflicts, clang-formatting

* rebase on upstream/develop, resolve conflicts, clang format

* Apply clang-formatting (clang-8.0.1), mv execute_in_serial function

* OpenMP fixes, clang-8 formatting

* Kokkos_OpenMP_Instance.hpp: add ";" to end of class definition

* Address round 3 of DA comments

* Fix typos in deprecation markings

* Fix CI failures in OpenACC, OpenMP, Threads backends

* rm conditional statement

* rm additional `in_parallel` statements

* Correctly flag namespace brace

* Address most recent DA comments

* rm brace at 3108

* rm else branch; change "==" to "=" in TestExecutionSpace

* Add deprecation marking for all `in_parallel`-requiring tests

* TestHPX_InParallel.cpp: rm unused variable "n"

* TestHPX_InParallel.cpp: put "n" inside of Deprecaton marking

* Add dep. marking to `impl_in_parallel_scope`-type statements

* Add deprecation marking to all impl_not_in_parallel_scope

* Address DLG comments

* rm errant "e += i"

* rm second definition of "execute_in_serial"

* Address DA comments

* Fix up function call operator

* Addressing final DA comments

* Apply deprecation markings uniformly

* Put deprecation markings around braced clauses

* Apply suggestions from review

---------

Co-authored-by: Damien L-G <dalg24@gmail.com>
The file was modified core/src/HPX/Kokkos_HPX.cpp (diff)
The file was modified core/src/impl/Kokkos_ViewMapping.hpp (diff)
The file was modified core/src/Cuda/Kokkos_Cuda.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.cpp (diff)
The file was modified core/unit_test/TestExecutionSpace.hpp (diff)
The file was modified core/src/SYCL/Kokkos_SYCL.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads.hpp (diff)
The file was modified core/src/HPX/Kokkos_HPX.hpp (diff)
The file was modified core/src/Threads/Kokkos_Threads_Instance.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP.cpp (diff)
The file was modified core/src/OpenMPTarget/Kokkos_OpenMPTarget.hpp (diff)
The file was modified core/src/OpenMP/Kokkos_OpenMP_Instance.hpp (diff)
The file was modified core/unit_test/incremental/Test01_execspace.hpp (diff)
The file was modified core/src/OpenACC/Kokkos_OpenACC.hpp (diff)
The file was modified core/src/HIP/Kokkos_HIP.hpp (diff)
The file was modified core/unit_test/CMakeLists.txt (diff)
Commit bbb895a347f4c511a9fc85193ca554f105e99739 by noreply
Remove redundant calls in rangepolicy constructors (#6765)

* Removed redudant calls from RangePolicy constructors

* Fixed to call the right constructor
The file was modified core/src/Kokkos_ExecPolicy.hpp (diff)