Skip to content
[Jenkins]Jenkins
log in
Failed

Changes

Summary

  1. Add `ATOMICS_BYPASS` configuration option to disable atomics (#6692) (details)
  2. Check matching static extents in View constructor (#5190) (details)
  3. Use cuda_stream/device also for UVM and HostPinned (details)
Commit 27286c32d7e0c157d1a4d7f00f9441979ed8eabe by noreply
Add `ATOMICS_BYPASS` configuration option to disable atomics (#6692)

* Add NAME_TBD_UNSAFE_ATOMICS configuration option to disable atomics

* Rename configuration option and macro NAME_TBD_UNSAFE_ATOMICS -> ATOMICS_BYPASS

* Improve option description and configuration time error message

Co-Authored-By: Christian Trott <crtrott@sandia.gov>
Co-Authored-By: Daniel Arndt <arndtd@ornl.gov>

* Mention Kokkos_ENABLE_ATOMICS_BYPASS option in error msssage

* Simplify sanity check for disabling atomics in <Kokkos_Macros.hpp>

Co-Authored-By: Daniel Arndt <arndtd@ornl.gov>

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
The file was modified cmake/kokkos_arch.cmake (diff)
The file was modified core/src/Serial/Kokkos_Serial.cpp (diff)
The file was modified cmake/kokkos_enable_options.cmake (diff)
The file was modified core/src/Kokkos_Atomics_Desul_Volatile_Wrapper.hpp (diff)
The file was modified cmake/KokkosCore_config.h.in (diff)
The file was modified core/src/Kokkos_Atomics_Desul_Wrapper.hpp (diff)
The file was modified core/src/Kokkos_Macros.hpp (diff)
Commit 0e4a158a7585f2a93b93d4121788016fe0dba4c9 by noreply
Check matching static extents in View constructor (#5190)

* Also check static extents

* Use separate bools for the two checks and improve error messages

* Improve error messages

* Refactor test

* Add another test

* Extend existing tests

* Use make_index_sequence

* Remove LIVE and DIE

* Try removing guards for OpenMPTarget

* Use different style in view_construction_with_wrong_static_extents

* Remove template template parameter

* Also check unmanaged views

* Fix DynRankView

* Add FIXME

* Pass label by const char *

* fix terminating define

* Deduce rank and dynamic_rank from View

* Only call runtime_check_rank when KOKKOS_ENABLE_DEBUG_BOUNDS_CHECK is defined

* Guard with if constexpr

---------

Co-authored-by: Francesco Rizzi <fnrizzi@sandia.gov>
The file was modified core/unit_test/TestViewCtorDimMatch.hpp (diff)
The file was modified containers/src/Kokkos_DynRankView.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewArray.hpp (diff)
The file was modified core/unit_test/TestViewAPI.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
Commit 26f1bb2c06cb49827ed7cd9e66c1013490a0de1b by Daniel Arndt
Use cuda_stream/device also for UVM and HostPinned
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.hpp (diff)

Summary

  1. Add `ATOMICS_BYPASS` configuration option to disable atomics (#6692) (details)
  2. Check matching static extents in View constructor (#5190) (details)
  3. Use cuda_stream/device also for UVM and HostPinned (details)
Commit 27286c32d7e0c157d1a4d7f00f9441979ed8eabe by noreply
Add `ATOMICS_BYPASS` configuration option to disable atomics (#6692)

* Add NAME_TBD_UNSAFE_ATOMICS configuration option to disable atomics

* Rename configuration option and macro NAME_TBD_UNSAFE_ATOMICS -> ATOMICS_BYPASS

* Improve option description and configuration time error message

Co-Authored-By: Christian Trott <crtrott@sandia.gov>
Co-Authored-By: Daniel Arndt <arndtd@ornl.gov>

* Mention Kokkos_ENABLE_ATOMICS_BYPASS option in error msssage

* Simplify sanity check for disabling atomics in <Kokkos_Macros.hpp>

Co-Authored-By: Daniel Arndt <arndtd@ornl.gov>

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
The file was modified cmake/KokkosCore_config.h.in (diff)
The file was modified core/src/Serial/Kokkos_Serial.cpp (diff)
The file was modified core/src/Kokkos_Atomics_Desul_Volatile_Wrapper.hpp (diff)
The file was modified core/src/Kokkos_Macros.hpp (diff)
The file was modified cmake/kokkos_arch.cmake (diff)
The file was modified cmake/kokkos_enable_options.cmake (diff)
The file was modified core/src/Kokkos_Atomics_Desul_Wrapper.hpp (diff)
Commit 0e4a158a7585f2a93b93d4121788016fe0dba4c9 by noreply
Check matching static extents in View constructor (#5190)

* Also check static extents

* Use separate bools for the two checks and improve error messages

* Improve error messages

* Refactor test

* Add another test

* Extend existing tests

* Use make_index_sequence

* Remove LIVE and DIE

* Try removing guards for OpenMPTarget

* Use different style in view_construction_with_wrong_static_extents

* Remove template template parameter

* Also check unmanaged views

* Fix DynRankView

* Add FIXME

* Pass label by const char *

* fix terminating define

* Deduce rank and dynamic_rank from View

* Only call runtime_check_rank when KOKKOS_ENABLE_DEBUG_BOUNDS_CHECK is defined

* Guard with if constexpr

---------

Co-authored-by: Francesco Rizzi <fnrizzi@sandia.gov>
The file was modified core/unit_test/TestViewCtorDimMatch.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewArray.hpp (diff)
The file was modified core/unit_test/TestViewAPI.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified containers/src/Kokkos_DynRankView.hpp (diff)
Commit 26f1bb2c06cb49827ed7cd9e66c1013490a0de1b by Daniel Arndt
Use cuda_stream/device also for UVM and HostPinned
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.hpp (diff)

Summary

  1. Add `ATOMICS_BYPASS` configuration option to disable atomics (#6692) (details)
  2. Check matching static extents in View constructor (#5190) (details)
  3. Use cuda_stream/device also for UVM and HostPinned (details)
Commit 27286c32d7e0c157d1a4d7f00f9441979ed8eabe by noreply
Add `ATOMICS_BYPASS` configuration option to disable atomics (#6692)

* Add NAME_TBD_UNSAFE_ATOMICS configuration option to disable atomics

* Rename configuration option and macro NAME_TBD_UNSAFE_ATOMICS -> ATOMICS_BYPASS

* Improve option description and configuration time error message

Co-Authored-By: Christian Trott <crtrott@sandia.gov>
Co-Authored-By: Daniel Arndt <arndtd@ornl.gov>

* Mention Kokkos_ENABLE_ATOMICS_BYPASS option in error msssage

* Simplify sanity check for disabling atomics in <Kokkos_Macros.hpp>

Co-Authored-By: Daniel Arndt <arndtd@ornl.gov>

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
The file was modified core/src/Kokkos_Macros.hpp (diff)
The file was modified cmake/kokkos_arch.cmake (diff)
The file was modified cmake/KokkosCore_config.h.in (diff)
The file was modified core/src/Kokkos_Atomics_Desul_Volatile_Wrapper.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.cpp (diff)
The file was modified cmake/kokkos_enable_options.cmake (diff)
The file was modified core/src/Kokkos_Atomics_Desul_Wrapper.hpp (diff)
Commit 0e4a158a7585f2a93b93d4121788016fe0dba4c9 by noreply
Check matching static extents in View constructor (#5190)

* Also check static extents

* Use separate bools for the two checks and improve error messages

* Improve error messages

* Refactor test

* Add another test

* Extend existing tests

* Use make_index_sequence

* Remove LIVE and DIE

* Try removing guards for OpenMPTarget

* Use different style in view_construction_with_wrong_static_extents

* Remove template template parameter

* Also check unmanaged views

* Fix DynRankView

* Add FIXME

* Pass label by const char *

* fix terminating define

* Deduce rank and dynamic_rank from View

* Only call runtime_check_rank when KOKKOS_ENABLE_DEBUG_BOUNDS_CHECK is defined

* Guard with if constexpr

---------

Co-authored-by: Francesco Rizzi <fnrizzi@sandia.gov>
The file was modified containers/src/Kokkos_DynRankView.hpp (diff)
The file was modified core/unit_test/TestViewAPI.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewArray.hpp (diff)
The file was modified core/unit_test/TestViewCtorDimMatch.hpp (diff)
Commit 26f1bb2c06cb49827ed7cd9e66c1013490a0de1b by Daniel Arndt
Use cuda_stream/device also for UVM and HostPinned
The file was modified core/src/Cuda/Kokkos_CudaSpace.hpp (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)

Summary

  1. Add `ATOMICS_BYPASS` configuration option to disable atomics (#6692) (details)
  2. Check matching static extents in View constructor (#5190) (details)
  3. Use cuda_stream/device also for UVM and HostPinned (details)
Commit 27286c32d7e0c157d1a4d7f00f9441979ed8eabe by noreply
Add `ATOMICS_BYPASS` configuration option to disable atomics (#6692)

* Add NAME_TBD_UNSAFE_ATOMICS configuration option to disable atomics

* Rename configuration option and macro NAME_TBD_UNSAFE_ATOMICS -> ATOMICS_BYPASS

* Improve option description and configuration time error message

Co-Authored-By: Christian Trott <crtrott@sandia.gov>
Co-Authored-By: Daniel Arndt <arndtd@ornl.gov>

* Mention Kokkos_ENABLE_ATOMICS_BYPASS option in error msssage

* Simplify sanity check for disabling atomics in <Kokkos_Macros.hpp>

Co-Authored-By: Daniel Arndt <arndtd@ornl.gov>

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
The file was modified cmake/kokkos_arch.cmake (diff)
The file was modified core/src/Kokkos_Atomics_Desul_Volatile_Wrapper.hpp (diff)
The file was modified core/src/Kokkos_Atomics_Desul_Wrapper.hpp (diff)
The file was modified core/src/Kokkos_Macros.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.cpp (diff)
The file was modified cmake/KokkosCore_config.h.in (diff)
The file was modified cmake/kokkos_enable_options.cmake (diff)
Commit 0e4a158a7585f2a93b93d4121788016fe0dba4c9 by noreply
Check matching static extents in View constructor (#5190)

* Also check static extents

* Use separate bools for the two checks and improve error messages

* Improve error messages

* Refactor test

* Add another test

* Extend existing tests

* Use make_index_sequence

* Remove LIVE and DIE

* Try removing guards for OpenMPTarget

* Use different style in view_construction_with_wrong_static_extents

* Remove template template parameter

* Also check unmanaged views

* Fix DynRankView

* Add FIXME

* Pass label by const char *

* fix terminating define

* Deduce rank and dynamic_rank from View

* Only call runtime_check_rank when KOKKOS_ENABLE_DEBUG_BOUNDS_CHECK is defined

* Guard with if constexpr

---------

Co-authored-by: Francesco Rizzi <fnrizzi@sandia.gov>
The file was modified containers/src/Kokkos_DynRankView.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewArray.hpp (diff)
The file was modified core/unit_test/TestViewCtorDimMatch.hpp (diff)
The file was modified core/unit_test/TestViewAPI.hpp (diff)
Commit 26f1bb2c06cb49827ed7cd9e66c1013490a0de1b by Daniel Arndt
Use cuda_stream/device also for UVM and HostPinned
The file was modified core/src/Cuda/Kokkos_CudaSpace.hpp (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)

Summary

  1. Add `ATOMICS_BYPASS` configuration option to disable atomics (#6692) (details)
  2. Check matching static extents in View constructor (#5190) (details)
  3. Use cuda_stream/device also for UVM and HostPinned (details)
Commit 27286c32d7e0c157d1a4d7f00f9441979ed8eabe by noreply
Add `ATOMICS_BYPASS` configuration option to disable atomics (#6692)

* Add NAME_TBD_UNSAFE_ATOMICS configuration option to disable atomics

* Rename configuration option and macro NAME_TBD_UNSAFE_ATOMICS -> ATOMICS_BYPASS

* Improve option description and configuration time error message

Co-Authored-By: Christian Trott <crtrott@sandia.gov>
Co-Authored-By: Daniel Arndt <arndtd@ornl.gov>

* Mention Kokkos_ENABLE_ATOMICS_BYPASS option in error msssage

* Simplify sanity check for disabling atomics in <Kokkos_Macros.hpp>

Co-Authored-By: Daniel Arndt <arndtd@ornl.gov>

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
The file was modified cmake/KokkosCore_config.h.in (diff)
The file was modified core/src/Kokkos_Macros.hpp (diff)
The file was modified core/src/Kokkos_Atomics_Desul_Wrapper.hpp (diff)
The file was modified cmake/kokkos_enable_options.cmake (diff)
The file was modified core/src/Kokkos_Atomics_Desul_Volatile_Wrapper.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.cpp (diff)
The file was modified cmake/kokkos_arch.cmake (diff)
Commit 0e4a158a7585f2a93b93d4121788016fe0dba4c9 by noreply
Check matching static extents in View constructor (#5190)

* Also check static extents

* Use separate bools for the two checks and improve error messages

* Improve error messages

* Refactor test

* Add another test

* Extend existing tests

* Use make_index_sequence

* Remove LIVE and DIE

* Try removing guards for OpenMPTarget

* Use different style in view_construction_with_wrong_static_extents

* Remove template template parameter

* Also check unmanaged views

* Fix DynRankView

* Add FIXME

* Pass label by const char *

* fix terminating define

* Deduce rank and dynamic_rank from View

* Only call runtime_check_rank when KOKKOS_ENABLE_DEBUG_BOUNDS_CHECK is defined

* Guard with if constexpr

---------

Co-authored-by: Francesco Rizzi <fnrizzi@sandia.gov>
The file was modified containers/src/Kokkos_DynRankView.hpp (diff)
The file was modified core/unit_test/TestViewAPI.hpp (diff)
The file was modified core/unit_test/TestViewCtorDimMatch.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewArray.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
Commit 26f1bb2c06cb49827ed7cd9e66c1013490a0de1b by Daniel Arndt
Use cuda_stream/device also for UVM and HostPinned
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.hpp (diff)

Summary

  1. Add `ATOMICS_BYPASS` configuration option to disable atomics (#6692) (details)
  2. Check matching static extents in View constructor (#5190) (details)
  3. Use cuda_stream/device also for UVM and HostPinned (details)
Commit 27286c32d7e0c157d1a4d7f00f9441979ed8eabe by noreply
Add `ATOMICS_BYPASS` configuration option to disable atomics (#6692)

* Add NAME_TBD_UNSAFE_ATOMICS configuration option to disable atomics

* Rename configuration option and macro NAME_TBD_UNSAFE_ATOMICS -> ATOMICS_BYPASS

* Improve option description and configuration time error message

Co-Authored-By: Christian Trott <crtrott@sandia.gov>
Co-Authored-By: Daniel Arndt <arndtd@ornl.gov>

* Mention Kokkos_ENABLE_ATOMICS_BYPASS option in error msssage

* Simplify sanity check for disabling atomics in <Kokkos_Macros.hpp>

Co-Authored-By: Daniel Arndt <arndtd@ornl.gov>

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
The file was modified cmake/kokkos_enable_options.cmake (diff)
The file was modified core/src/Kokkos_Atomics_Desul_Volatile_Wrapper.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.cpp (diff)
The file was modified cmake/KokkosCore_config.h.in (diff)
The file was modified cmake/kokkos_arch.cmake (diff)
The file was modified core/src/Kokkos_Atomics_Desul_Wrapper.hpp (diff)
The file was modified core/src/Kokkos_Macros.hpp (diff)
Commit 0e4a158a7585f2a93b93d4121788016fe0dba4c9 by noreply
Check matching static extents in View constructor (#5190)

* Also check static extents

* Use separate bools for the two checks and improve error messages

* Improve error messages

* Refactor test

* Add another test

* Extend existing tests

* Use make_index_sequence

* Remove LIVE and DIE

* Try removing guards for OpenMPTarget

* Use different style in view_construction_with_wrong_static_extents

* Remove template template parameter

* Also check unmanaged views

* Fix DynRankView

* Add FIXME

* Pass label by const char *

* fix terminating define

* Deduce rank and dynamic_rank from View

* Only call runtime_check_rank when KOKKOS_ENABLE_DEBUG_BOUNDS_CHECK is defined

* Guard with if constexpr

---------

Co-authored-by: Francesco Rizzi <fnrizzi@sandia.gov>
The file was modified containers/src/Kokkos_DynRankView.hpp (diff)
The file was modified core/unit_test/TestViewAPI.hpp (diff)
The file was modified core/unit_test/TestViewCtorDimMatch.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewArray.hpp (diff)
Commit 26f1bb2c06cb49827ed7cd9e66c1013490a0de1b by Daniel Arndt
Use cuda_stream/device also for UVM and HostPinned
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.hpp (diff)

Summary

  1. Add `ATOMICS_BYPASS` configuration option to disable atomics (#6692) (details)
  2. Check matching static extents in View constructor (#5190) (details)
  3. Use cuda_stream/device also for UVM and HostPinned (details)
Commit 27286c32d7e0c157d1a4d7f00f9441979ed8eabe by noreply
Add `ATOMICS_BYPASS` configuration option to disable atomics (#6692)

* Add NAME_TBD_UNSAFE_ATOMICS configuration option to disable atomics

* Rename configuration option and macro NAME_TBD_UNSAFE_ATOMICS -> ATOMICS_BYPASS

* Improve option description and configuration time error message

Co-Authored-By: Christian Trott <crtrott@sandia.gov>
Co-Authored-By: Daniel Arndt <arndtd@ornl.gov>

* Mention Kokkos_ENABLE_ATOMICS_BYPASS option in error msssage

* Simplify sanity check for disabling atomics in <Kokkos_Macros.hpp>

Co-Authored-By: Daniel Arndt <arndtd@ornl.gov>

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
The file was modified cmake/KokkosCore_config.h.in (diff)
The file was modified core/src/Serial/Kokkos_Serial.cpp (diff)
The file was modified cmake/kokkos_arch.cmake (diff)
The file was modified core/src/Kokkos_Macros.hpp (diff)
The file was modified cmake/kokkos_enable_options.cmake (diff)
The file was modified core/src/Kokkos_Atomics_Desul_Volatile_Wrapper.hpp (diff)
The file was modified core/src/Kokkos_Atomics_Desul_Wrapper.hpp (diff)
Commit 0e4a158a7585f2a93b93d4121788016fe0dba4c9 by noreply
Check matching static extents in View constructor (#5190)

* Also check static extents

* Use separate bools for the two checks and improve error messages

* Improve error messages

* Refactor test

* Add another test

* Extend existing tests

* Use make_index_sequence

* Remove LIVE and DIE

* Try removing guards for OpenMPTarget

* Use different style in view_construction_with_wrong_static_extents

* Remove template template parameter

* Also check unmanaged views

* Fix DynRankView

* Add FIXME

* Pass label by const char *

* fix terminating define

* Deduce rank and dynamic_rank from View

* Only call runtime_check_rank when KOKKOS_ENABLE_DEBUG_BOUNDS_CHECK is defined

* Guard with if constexpr

---------

Co-authored-by: Francesco Rizzi <fnrizzi@sandia.gov>
The file was modified core/unit_test/TestViewAPI.hpp (diff)
The file was modified containers/src/Kokkos_DynRankView.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified core/src/impl/Kokkos_ViewArray.hpp (diff)
The file was modified core/unit_test/TestViewCtorDimMatch.hpp (diff)
Commit 26f1bb2c06cb49827ed7cd9e66c1013490a0de1b by Daniel Arndt
Use cuda_stream/device also for UVM and HostPinned
The file was modified core/src/Cuda/Kokkos_CudaSpace.cpp (diff)
The file was modified core/src/Cuda/Kokkos_CudaSpace.hpp (diff)