Skip to content
Failed

Changes

Summary

  1. Drop Experimental::LayoutTiled class template (details)
  2. Get rid of now unnecessary use of is_layouttiled trait (details)
  3. Deprecate is_layouttiled trait (details)
  4. SYCL: Improve team_reduce implementation (#6562) (details)
  5. Revert "Remove m_thread_team_data_mutex" (details)
Commit e2cfdec5434e1b0e8ff9a47c081fcc49ad3f8550 by Damien L-G
Drop Experimental::LayoutTiled class template
The file was removedcore/src/impl/Kokkos_ViewLayoutTiled.hpp
The file was modified core/unit_test/TestOther.hpp (diff)
The file was removedcore/unit_test/TestViewLayoutTiled.hpp
The file was modified core/src/Kokkos_Layout.hpp (diff)
Commit 51b98e1d76b198478b3975ff738a99272450c67e by Damien L-G
Get rid of now unnecessary use of is_layouttiled trait
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified core/src/Kokkos_CopyViews.hpp (diff)
The file was modified containers/src/Kokkos_DynRankView.hpp (diff)
Commit 1efeb5d76d677e68701cd9592d475ee56f5a1dbc by Damien L-G
Deprecate is_layouttiled trait
The file was modified core/src/Kokkos_Layout.hpp (diff)
Commit 98b1a38e5391c57b866c4b16bf8108fce56d827a by noreply
SYCL: Improve team_reduce implementation (#6562)

* SYCL: Improve team_reduce implementation

* Manually unroll loop to propagate shuffle destinations at compile-time

* Update step_width

* Fix sign comparison warnings

* Comment and choosing step_width=16

* KOKKOS_ASSERT that the subgroup range doesn't exceed 32

* Remove unattainable cases

* Add a barrier guarding the reduction array upon exiting team_reduce

* Update comment to better reflect intent of barrier

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
The file was modified core/src/SYCL/Kokkos_SYCL_Team.hpp (diff)
Commit d2f0c00c41a6ac82989fd53640a9cc9323ff2846 by Daniel Arndt
Revert "Remove m_thread_team_data_mutex"

This reverts commit ac408ddfe4c3ae327f014d2c6dad31b71b3519c0.
The file was modified core/src/Serial/Kokkos_Serial_Parallel_MDRange.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial_Parallel_Range.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial_Parallel_Team.hpp (diff)

Summary

  1. Drop Experimental::LayoutTiled class template (details)
  2. Get rid of now unnecessary use of is_layouttiled trait (details)
  3. Deprecate is_layouttiled trait (details)
  4. SYCL: Improve team_reduce implementation (#6562) (details)
  5. Revert "Remove m_thread_team_data_mutex" (details)
Commit e2cfdec5434e1b0e8ff9a47c081fcc49ad3f8550 by Damien L-G
Drop Experimental::LayoutTiled class template
The file was modified core/src/Kokkos_Layout.hpp (diff)
The file was removedcore/src/impl/Kokkos_ViewLayoutTiled.hpp
The file was modified core/unit_test/TestOther.hpp (diff)
The file was removedcore/unit_test/TestViewLayoutTiled.hpp
Commit 51b98e1d76b198478b3975ff738a99272450c67e by Damien L-G
Get rid of now unnecessary use of is_layouttiled trait
The file was modified core/src/Kokkos_CopyViews.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified containers/src/Kokkos_DynRankView.hpp (diff)
Commit 1efeb5d76d677e68701cd9592d475ee56f5a1dbc by Damien L-G
Deprecate is_layouttiled trait
The file was modified core/src/Kokkos_Layout.hpp (diff)
Commit 98b1a38e5391c57b866c4b16bf8108fce56d827a by noreply
SYCL: Improve team_reduce implementation (#6562)

* SYCL: Improve team_reduce implementation

* Manually unroll loop to propagate shuffle destinations at compile-time

* Update step_width

* Fix sign comparison warnings

* Comment and choosing step_width=16

* KOKKOS_ASSERT that the subgroup range doesn't exceed 32

* Remove unattainable cases

* Add a barrier guarding the reduction array upon exiting team_reduce

* Update comment to better reflect intent of barrier

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
The file was modified core/src/SYCL/Kokkos_SYCL_Team.hpp (diff)
Commit d2f0c00c41a6ac82989fd53640a9cc9323ff2846 by Daniel Arndt
Revert "Remove m_thread_team_data_mutex"

This reverts commit ac408ddfe4c3ae327f014d2c6dad31b71b3519c0.
The file was modified core/src/Serial/Kokkos_Serial_Parallel_Team.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial_Parallel_Range.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial_Parallel_MDRange.hpp (diff)

Summary

  1. Drop Experimental::LayoutTiled class template (details)
  2. Get rid of now unnecessary use of is_layouttiled trait (details)
  3. Deprecate is_layouttiled trait (details)
  4. SYCL: Improve team_reduce implementation (#6562) (details)
  5. Revert "Remove m_thread_team_data_mutex" (details)
Commit e2cfdec5434e1b0e8ff9a47c081fcc49ad3f8550 by Damien L-G
Drop Experimental::LayoutTiled class template
The file was removedcore/unit_test/TestViewLayoutTiled.hpp
The file was modified core/src/Kokkos_Layout.hpp (diff)
The file was removedcore/src/impl/Kokkos_ViewLayoutTiled.hpp
The file was modified core/unit_test/TestOther.hpp (diff)
Commit 51b98e1d76b198478b3975ff738a99272450c67e by Damien L-G
Get rid of now unnecessary use of is_layouttiled trait
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified core/src/Kokkos_CopyViews.hpp (diff)
The file was modified containers/src/Kokkos_DynRankView.hpp (diff)
Commit 1efeb5d76d677e68701cd9592d475ee56f5a1dbc by Damien L-G
Deprecate is_layouttiled trait
The file was modified core/src/Kokkos_Layout.hpp (diff)
Commit 98b1a38e5391c57b866c4b16bf8108fce56d827a by noreply
SYCL: Improve team_reduce implementation (#6562)

* SYCL: Improve team_reduce implementation

* Manually unroll loop to propagate shuffle destinations at compile-time

* Update step_width

* Fix sign comparison warnings

* Comment and choosing step_width=16

* KOKKOS_ASSERT that the subgroup range doesn't exceed 32

* Remove unattainable cases

* Add a barrier guarding the reduction array upon exiting team_reduce

* Update comment to better reflect intent of barrier

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
The file was modified core/src/SYCL/Kokkos_SYCL_Team.hpp (diff)
Commit d2f0c00c41a6ac82989fd53640a9cc9323ff2846 by Daniel Arndt
Revert "Remove m_thread_team_data_mutex"

This reverts commit ac408ddfe4c3ae327f014d2c6dad31b71b3519c0.
The file was modified core/src/Serial/Kokkos_Serial_Parallel_Team.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial_Parallel_MDRange.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial_Parallel_Range.hpp (diff)

Summary

  1. Drop Experimental::LayoutTiled class template (details)
  2. Get rid of now unnecessary use of is_layouttiled trait (details)
  3. Deprecate is_layouttiled trait (details)
  4. SYCL: Improve team_reduce implementation (#6562) (details)
  5. Revert "Remove m_thread_team_data_mutex" (details)
Commit e2cfdec5434e1b0e8ff9a47c081fcc49ad3f8550 by Damien L-G
Drop Experimental::LayoutTiled class template
The file was removedcore/src/impl/Kokkos_ViewLayoutTiled.hpp
The file was modified core/src/Kokkos_Layout.hpp (diff)
The file was removedcore/unit_test/TestViewLayoutTiled.hpp
The file was modified core/unit_test/TestOther.hpp (diff)
Commit 51b98e1d76b198478b3975ff738a99272450c67e by Damien L-G
Get rid of now unnecessary use of is_layouttiled trait
The file was modified containers/src/Kokkos_DynRankView.hpp (diff)
The file was modified core/src/Kokkos_CopyViews.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
Commit 1efeb5d76d677e68701cd9592d475ee56f5a1dbc by Damien L-G
Deprecate is_layouttiled trait
The file was modified core/src/Kokkos_Layout.hpp (diff)
Commit 98b1a38e5391c57b866c4b16bf8108fce56d827a by noreply
SYCL: Improve team_reduce implementation (#6562)

* SYCL: Improve team_reduce implementation

* Manually unroll loop to propagate shuffle destinations at compile-time

* Update step_width

* Fix sign comparison warnings

* Comment and choosing step_width=16

* KOKKOS_ASSERT that the subgroup range doesn't exceed 32

* Remove unattainable cases

* Add a barrier guarding the reduction array upon exiting team_reduce

* Update comment to better reflect intent of barrier

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
The file was modified core/src/SYCL/Kokkos_SYCL_Team.hpp (diff)
Commit d2f0c00c41a6ac82989fd53640a9cc9323ff2846 by Daniel Arndt
Revert "Remove m_thread_team_data_mutex"

This reverts commit ac408ddfe4c3ae327f014d2c6dad31b71b3519c0.
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial_Parallel_MDRange.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial_Parallel_Range.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial_Parallel_Team.hpp (diff)

Summary

  1. Drop Experimental::LayoutTiled class template (details)
  2. Get rid of now unnecessary use of is_layouttiled trait (details)
  3. Deprecate is_layouttiled trait (details)
  4. SYCL: Improve team_reduce implementation (#6562) (details)
  5. Revert "Remove m_thread_team_data_mutex" (details)
Commit e2cfdec5434e1b0e8ff9a47c081fcc49ad3f8550 by Damien L-G
Drop Experimental::LayoutTiled class template
The file was modified core/src/Kokkos_Layout.hpp (diff)
The file was modified core/unit_test/TestOther.hpp (diff)
The file was removedcore/unit_test/TestViewLayoutTiled.hpp
The file was removedcore/src/impl/Kokkos_ViewLayoutTiled.hpp
Commit 51b98e1d76b198478b3975ff738a99272450c67e by Damien L-G
Get rid of now unnecessary use of is_layouttiled trait
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified containers/src/Kokkos_DynRankView.hpp (diff)
The file was modified core/src/Kokkos_CopyViews.hpp (diff)
Commit 1efeb5d76d677e68701cd9592d475ee56f5a1dbc by Damien L-G
Deprecate is_layouttiled trait
The file was modified core/src/Kokkos_Layout.hpp (diff)
Commit 98b1a38e5391c57b866c4b16bf8108fce56d827a by noreply
SYCL: Improve team_reduce implementation (#6562)

* SYCL: Improve team_reduce implementation

* Manually unroll loop to propagate shuffle destinations at compile-time

* Update step_width

* Fix sign comparison warnings

* Comment and choosing step_width=16

* KOKKOS_ASSERT that the subgroup range doesn't exceed 32

* Remove unattainable cases

* Add a barrier guarding the reduction array upon exiting team_reduce

* Update comment to better reflect intent of barrier

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
The file was modified core/src/SYCL/Kokkos_SYCL_Team.hpp (diff)
Commit d2f0c00c41a6ac82989fd53640a9cc9323ff2846 by Daniel Arndt
Revert "Remove m_thread_team_data_mutex"

This reverts commit ac408ddfe4c3ae327f014d2c6dad31b71b3519c0.
The file was modified core/src/Serial/Kokkos_Serial_Parallel_MDRange.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial_Parallel_Team.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial_Parallel_Range.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)

Summary

  1. Drop Experimental::LayoutTiled class template (details)
  2. Get rid of now unnecessary use of is_layouttiled trait (details)
  3. Deprecate is_layouttiled trait (details)
  4. SYCL: Improve team_reduce implementation (#6562) (details)
  5. Revert "Remove m_thread_team_data_mutex" (details)
Commit e2cfdec5434e1b0e8ff9a47c081fcc49ad3f8550 by Damien L-G
Drop Experimental::LayoutTiled class template
The file was modified core/unit_test/TestOther.hpp (diff)
The file was modified core/src/Kokkos_Layout.hpp (diff)
The file was removedcore/unit_test/TestViewLayoutTiled.hpp
The file was removedcore/src/impl/Kokkos_ViewLayoutTiled.hpp
Commit 51b98e1d76b198478b3975ff738a99272450c67e by Damien L-G
Get rid of now unnecessary use of is_layouttiled trait
The file was modified containers/src/Kokkos_DynRankView.hpp (diff)
The file was modified core/src/Kokkos_View.hpp (diff)
The file was modified core/src/Kokkos_CopyViews.hpp (diff)
Commit 1efeb5d76d677e68701cd9592d475ee56f5a1dbc by Damien L-G
Deprecate is_layouttiled trait
The file was modified core/src/Kokkos_Layout.hpp (diff)
Commit 98b1a38e5391c57b866c4b16bf8108fce56d827a by noreply
SYCL: Improve team_reduce implementation (#6562)

* SYCL: Improve team_reduce implementation

* Manually unroll loop to propagate shuffle destinations at compile-time

* Update step_width

* Fix sign comparison warnings

* Comment and choosing step_width=16

* KOKKOS_ASSERT that the subgroup range doesn't exceed 32

* Remove unattainable cases

* Add a barrier guarding the reduction array upon exiting team_reduce

* Update comment to better reflect intent of barrier

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
The file was modified core/src/SYCL/Kokkos_SYCL_Team.hpp (diff)
Commit d2f0c00c41a6ac82989fd53640a9cc9323ff2846 by Daniel Arndt
Revert "Remove m_thread_team_data_mutex"

This reverts commit ac408ddfe4c3ae327f014d2c6dad31b71b3519c0.
The file was modified core/src/Serial/Kokkos_Serial.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial_Parallel_Team.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial_Parallel_MDRange.hpp (diff)
The file was modified core/src/Serial/Kokkos_Serial_Parallel_Range.hpp (diff)