Skip to content
Failed

Changes

Summary

  1. Introduce PairValueIndex and AttachIndices (details)
  2. Fix MLS (details)
  3. Move AttachIndices to Experimental and add attach_indices (details)
Commit 01befa6874c577e5eb1dffda5bfb5cc45d869a3b by Andrey Prokopenko
Introduce PairValueIndex and AttachIndices

There are two use cases that are currently mixed when using
LegacyValues:

1) Legacy classes use LegacyValues to pass to the new interface
2) User wants to attach indices to the passed primitives without
   constructing them themselves

The difference is that 1) should not be exposed to a user, while 2) is
intended to.

With the introduction of the RangeTraits in the future, the use cases
diverge: 1) will still use AccessTraits for backwards compatibility,
while 2) will switch to using RangeTraits.

This patch separates the two. They still share a lot of commonalities at
the moment, but that will change with RangeTraits.

In addition, the order is swapped between value and index in the struct.
The reason being is that it is easer to align an index (likely 4-byte
int) than a value (which could be a 12-byte point, 24-byte box, or
whatever).
The file was modified src/ArborX_LinearBVH.hpp (diff)
The file was modified benchmarks/dbscan/ArborX_DBSCANVerification.hpp (diff)
The file was modified src/details/ArborX_DetailsHappyTreeFriends.hpp (diff)
The file was modified test/tstDetailsMutualReachabilityDistance.cpp (diff)
The file was modified src/details/ArborX_MinimumSpanningTree.hpp (diff)
The file was modified src/details/ArborX_DetailsNode.hpp (diff)
The file was modified src/ArborX_DBSCAN.hpp (diff)
The file was modified test/tstDetailsTreeConstruction.cpp (diff)
The file was modified examples/triangle_intersection/triangle_intersection.cpp (diff)
The file was modified src/details/ArborX_IndexableGetter.hpp (diff)
The file was addedsrc/details/ArborX_PairValueIndex.hpp
The file was modified benchmarks/brute_force_vs_bvh/brute_force_vs_bvh_timpl.hpp (diff)
The file was modified src/details/ArborX_DetailsLegacy.hpp (diff)
The file was modified src/ArborX_BruteForce.hpp (diff)
The file was modified test/CMakeLists.txt (diff)
The file was modified src/interpolation/ArborX_InterpMovingLeastSquares.hpp (diff)
Commit 2f317e634370c239c8bda7b64c5b458989a3b5a8 by Andrey Prokopenko
Move AttachIndices to Experimental and add attach_indices
The file was modified src/details/ArborX_MinimumSpanningTree.hpp (diff)
The file was modified src/interpolation/ArborX_InterpMovingLeastSquares.hpp (diff)
The file was modified benchmarks/brute_force_vs_bvh/brute_force_vs_bvh_timpl.hpp (diff)
The file was modified src/details/ArborX_PairValueIndex.hpp (diff)
The file was modified examples/triangle_intersection/triangle_intersection.cpp (diff)
The file was modified src/ArborX_DBSCAN.hpp (diff)
The file was modified benchmarks/dbscan/ArborX_DBSCANVerification.hpp (diff)
The file was modified test/tstDetailsMutualReachabilityDistance.cpp (diff)